platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java - Issue 1547923002: SampleApp: remove SkWindow::onPDFSaved, it does not work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java

Issue 1547923002: SampleApp: remove SkWindow::onPDFSaved, it does not work (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleActivity.java ('k') | platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java

diff --git a/platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java b/platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java

index c33f8ae8acf3d290eac1325dee34ee6ab0b847d6..6213a6f35be2b06a6fef620d81a99f90537643a7 100644

--- a/platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java

+++ b/platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java

@@ -18,6 +18,7 @@ import android.opengl.GLSurfaceView;

import android.os.Build;

import android.util.Log;

import android.view.MotionEvent;

+import android.widget.Toast;

public class SkiaSampleView extends GLSurfaceView {

@@ -177,6 +178,9 @@ public class SkiaSampleView extends GLSurfaceView {

mSampleRenderer.saveToPDF();

}

});

+ String msg = getContext().getString(R.string.pdf_save_info);

+ Toast.makeText(getContext(), msg, Toast.LENGTH_SHORT).show();

}

public boolean getUsesOpenGLAPI() {