Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1547403002: Move ownership of ChromeBrowserStateManager to ApplicationContext. (Closed)

Created:
4 years, 11 months ago by sdefresne
Modified:
4 years, 11 months ago
Reviewers:
jif
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ownership of ChromeBrowserStateManager to ApplicationContext. Keep the Shutdown method as removing it will require some downstream refactoring first. BUG=560854 Committed: https://crrev.com/2510e003371f9a38ba791b3a30323418a8d73db0 Cr-Commit-Position: refs/heads/master@{#367071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M ios/chrome/browser/application_context_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/application_context_impl.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.cc View 4 chunks +9 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
4 years, 11 months ago (2015-12-29 14:32:48 UTC) #2
jif
lgtm
4 years, 11 months ago (2015-12-29 14:38:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547403002/1
4 years, 11 months ago (2015-12-29 14:38:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 14:48:11 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 14:49:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2510e003371f9a38ba791b3a30323418a8d73db0
Cr-Commit-Position: refs/heads/master@{#367071}

Powered by Google App Engine
This is Rietveld 408576698