jingle/glue/proxy_resolving_client_socket.cc - Issue 1547273003: Set trusted SPDY proxy dynamically on per-profile basis

Unified Diff: jingle/glue/proxy_resolving_client_socket.cc

Issue 1547273003: Set trusted SPDY proxy dynamically on per-profile basis (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, addressed comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: jingle/glue/proxy_resolving_client_socket.cc

diff --git a/jingle/glue/proxy_resolving_client_socket.cc b/jingle/glue/proxy_resolving_client_socket.cc

index e54ca934cc369dd5811192e54711689fb4504269..32a4e31632cebf270bbf94b6b89c93362c8b3b36 100644

--- a/jingle/glue/proxy_resolving_client_socket.cc

+++ b/jingle/glue/proxy_resolving_client_socket.cc

@@ -84,7 +84,6 @@ ProxyResolvingClientSocket::ProxyResolvingClientSocket(

session_params.testing_fixed_https_port =

reference_params->testing_fixed_https_port;

session_params.next_protos = reference_params->next_protos;

- session_params.trusted_spdy_proxy = reference_params->trusted_spdy_proxy;

session_params.forced_spdy_exclusions =

mmenke 2016/02/02 16:51:26 You should talk to the owners of this file about t

tbansal1 2016/02/02 18:18:44 I do not understand this comment. Currently, Proxy

mmenke 2016/02/02 18:45:02 Right, but trusted_spdy_proxy was being copied, as

tbansal1 2016/02/02 19:34:32 Acked, the concept of trusted SPDY proxy is gettin

reference_params->forced_spdy_exclusions;

session_params.parse_alternative_services =

« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc ('k') | net/base/proxy_delegate.h » ('j') | net/base/proxy_delegate.h » ('J')