Set trusted SPDY proxy dynamically on per-profile basis

jingle/glue/proxy_resolving_client_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "jingle/glue/proxy_resolving_client_socket.h"
 
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 66 matching lines @@
     // TODO(mmenke):  Just copying specific parameters seems highly regression
     // prone.  Should have a better way to do this.
     session_params.host_mapping_rules = reference_params->host_mapping_rules;
     session_params.ignore_certificate_errors =
         reference_params->ignore_certificate_errors;
     session_params.testing_fixed_http_port =
         reference_params->testing_fixed_http_port;
     session_params.testing_fixed_https_port =
         reference_params->testing_fixed_https_port;
     session_params.next_protos = reference_params->next_protos;
-    session_params.trusted_spdy_proxy = reference_params->trusted_spdy_proxy;
     session_params.forced_spdy_exclusions =

[mmenke, 2016/02/02 16:51:26]

You should talk to the owners of this file about this change.  This doesn't copy
the ProxyDelegate*, so you're changing behavior here.

[tbansal1, 2016/02/02 18:18:44]

I do not understand this comment. Currently, ProxyDelegate* is not being copied.
And, this CL is not changing that behavior.

Also, this code is related to XMPP/WebRTC where it is not not useful to enable
SPDY push.

[mmenke, 2016/02/02 18:45:02]

Right, but trusted_spdy_proxy was being copied, as is the network_delegate.

[tbansal1, 2016/02/02 19:34:32]

Acked, the concept of trusted SPDY proxy is getting removed by this CL. I am
pretty sure it is okay but I will check with the jingle/ OWNERS.

         reference_params->forced_spdy_exclusions;
     session_params.parse_alternative_services =
         reference_params->parse_alternative_services;
     session_params.enable_alternative_service_with_different_host =
         reference_params->enable_alternative_service_with_different_host;
   }
 
   network_session_.reset(new net::HttpNetworkSession(session_params));
 }
 
@@ skipping 334 matching lines @@
   return 0;
 }
 
 void ProxyResolvingClientSocket::CloseTransportSocket() {
   if (transport_.get() && transport_->socket())
     transport_->socket()->Disconnect();
   transport_.reset();
 }
 
 }  // namespace jingle_glue