Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1547143002: Thread up two new V8 UseCounters for ES2015 RegExp compat (Closed)

Created:
4 years, 12 months ago by Dan Ehrenberg
Modified:
4 years, 11 months ago
Reviewers:
haraken, Nate Chapin
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Thread up two new V8 UseCounters for ES2015 RegExp compat These UseCounters were added in the V8 patch at https://codereview.chromium.org/1545633002 They track how often web compatibility-driven workarounds to the ES2015 spec are triggered. If the frequency goes down over time, then we can remove one or both of them. R=japhet@chromium.org CC=yangguo BUG=v8:4637, v8:4617 Committed: https://crrev.com/3cdcef55d54c954da0eb448301ba53ee23ea37f4 Cr-Commit-Position: refs/heads/master@{#366891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dan Ehrenberg
4 years, 12 months ago (2015-12-25 21:09:11 UTC) #1
haraken
LGTM
4 years, 12 months ago (2015-12-26 01:36:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547143002/1
4 years, 12 months ago (2015-12-26 02:59:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-26 04:19:31 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3cdcef55d54c954da0eb448301ba53ee23ea37f4 Cr-Commit-Position: refs/heads/master@{#366891}
4 years, 12 months ago (2015-12-26 04:20:59 UTC) #7
Rick Byers
4 years, 11 months ago (2016-01-04 18:52:32 UTC) #8
Message was sent while issue was closed.
On 2015/12/26 04:20:59, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/3cdcef55d54c954da0eb448301ba53ee23ea37f4
> Cr-Commit-Position: refs/heads/master@{#366891}

Note that this CL failed to follow the instructions in UseCounter.h for updating
histograms.xml.  The histograms.xml updates for this change are currently lumped
into my CL here: https://codereview.chromium.org/1554963003/

Powered by Google App Engine
This is Rietveld 408576698