content/browser/android/java/gin_java_bridge_message_filter.h - Issue 1547043002: [Android] Fix GinJavaBridgeMessageFilter registration issue in Java Bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/java/gin_java_bridge_message_filter.h

Issue 1547043002: [Android] Fix GinJavaBridgeMessageFilter registration issue in Java Bridge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses review inputs. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/java/gin_java_bridge_dispatcher_host.cc ('k') | content/browser/android/java/gin_java_bridge_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/java/gin_java_bridge_message_filter.h

diff --git a/content/browser/android/java/gin_java_bridge_message_filter.h b/content/browser/android/java/gin_java_bridge_message_filter.h

index 40165a81d1d6c1c70b8e31f11b7da61ddc4277db..ee5051af76be88a8ec16321f81c6039e104c0784 100644

--- a/content/browser/android/java/gin_java_bridge_message_filter.h

+++ b/content/browser/android/java/gin_java_bridge_message_filter.h

@@ -45,6 +45,11 @@ class GinJavaBridgeMessageFilter : public BrowserMessageFilter {

static scoped_refptr<GinJavaBridgeMessageFilter> FromHost(

GinJavaBridgeDispatcherHost* host, bool create_if_not_exists);

+ // Removes the filter, which triggers its deletion. Needs to be called when

+ // the corresponding RenderProcessHost cleans itself up, e.g. on renderer

+ // process exit.

+ static void RemoveFilter(GinJavaBridgeDispatcherHost* host);

private:

friend class BrowserThread;

friend class base::DeleteHelper<GinJavaBridgeMessageFilter>;