content/browser/android/java/gin_java_bridge_dispatcher_host.cc - Issue 1547043002: [Android] Fix GinJavaBridgeMessageFilter registration issue in Java Bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/java/gin_java_bridge_dispatcher_host.cc

Issue 1547043002: [Android] Fix GinJavaBridgeMessageFilter registration issue in Java Bridge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses review inputs. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/java/gin_java_bridge_dispatcher_host.h ('k') | content/browser/android/java/gin_java_bridge_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/java/gin_java_bridge_dispatcher_host.cc

diff --git a/content/browser/android/java/gin_java_bridge_dispatcher_host.cc b/content/browser/android/java/gin_java_bridge_dispatcher_host.cc

index 5063273c85ed3ebf7b3db57ea0c2347d6b8921a7..2de4f9fef0fb27a92251c5c0880c8b021f22214a 100644

--- a/content/browser/android/java/gin_java_bridge_dispatcher_host.cc

+++ b/content/browser/android/java/gin_java_bridge_dispatcher_host.cc

@@ -80,6 +80,20 @@ void GinJavaBridgeDispatcherHost::WebContentsDestroyed() {

filter->RemoveHost(this);

}

+void GinJavaBridgeDispatcherHost::RenderProcessGone(

+ base::TerminationStatus status) {

+ GinJavaBridgeMessageFilter::RemoveFilter(this);

+void GinJavaBridgeDispatcherHost::RenderViewHostChanged(

+ RenderViewHost* old_host,

+ RenderViewHost* new_host) {

+ scoped_refptr<GinJavaBridgeMessageFilter> filter =

+ GinJavaBridgeMessageFilter::FromHost(this, false);

+ if (!filter)

+ InstallFilterAndRegisterAllRoutingIds();

GinJavaBoundObject::ObjectID GinJavaBridgeDispatcherHost::AddObject(

const base::android::JavaRef<jobject>& object,

const base::android::JavaRef<jclass>& safe_annotation_clazz,