chrome/browser/resources/settings/site_settings_page/site_settings_page.js - Issue 1546993003: Site Settings: Give each category its own route.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.js

Issue 1546993003: Site Settings: Give each category its own route. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback and add some tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/site_settings/site_settings_behavior.js ('K') | « chrome/browser/resources/settings/site_settings/site_settings_category.js ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.js

diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js

index b7375408644a0efd290c591fdf379216a97d2628..b9e5f7362f9c4b984a811fab4865760a9d5fc692 100644

--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js

+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js

@@ -59,7 +59,7 @@ Polymer({

this.addCategory(settings.ContentSettingsTypes.JAVASCRIPT);

this.addCategory(settings.ContentSettingsTypes.POPUPS);

this.addCategory(settings.ContentSettingsTypes.FULLSCREEN);

- this.addCategory(settings.ContentSettingsTypes.NOTIFICATION);

+ this.addCategory(settings.ContentSettingsTypes.NOTIFICATIONS);

this.addCategory(settings.ContentSettingsTypes.IMAGES);

}.bind(this));

@@ -102,10 +102,11 @@ Polymer({

var description = event.currentTarget.querySelector('.flex').innerText;

this.categorySelected = this.computeCategoryFromDesc(description);

+ var page = this.computeCategoryTextId(this.categorySelected);

this.currentRoute = {

page: this.currentRoute.page,

section: 'privacy',

- subpage: ['site-settings', 'site-settings-category'],

+ subpage: ['site-settings', 'site-settings-category-' + page],

};

});