chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 1546993003: Site Settings: Give each category its own route.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 1546993003: Site Settings: Give each category its own route. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings_page/site_settings_page.js ('k') | chrome/test/data/webui/settings/site_settings_category_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index a9d43ef4750c48f15cbc56a63c0bd07b37a3466e..f5cf4836ecf86669a00c102e532dc3a890f64927 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -605,12 +605,26 @@ void AddSearchEnginesStrings(content::WebUIDataSource* html_source) {

}

void AddSiteSettingsStrings(content::WebUIDataSource* html_source) {

- html_source->AddLocalizedString("siteSettingsPageTitle",

- IDS_SETTINGS_SITE_SETTINGS);

- // TODO(finnur): Would be nice to show 'Location'/'Camera' instead of hard-

- // coding this.

html_source->AddLocalizedString("siteSettingsCategoryPageTitle",

IDS_SETTINGS_SITE_SETTINGS_CATEGORY);

+ html_source->AddLocalizedString("siteSettingsCategoryCamera",

+ IDS_SETTINGS_SITE_SETTINGS_CAMERA);

+ html_source->AddLocalizedString("siteSettingsCategoryCookies",

+ IDS_SETTINGS_SITE_SETTINGS_COOKIES);

+ html_source->AddLocalizedString("siteSettingsCategoryFullscreen",

+ IDS_SETTINGS_SITE_SETTINGS_FULLSCREEN);

+ html_source->AddLocalizedString("siteSettingsCategoryImages",

+ IDS_SETTINGS_SITE_SETTINGS_IMAGES);

+ html_source->AddLocalizedString("siteSettingsCategoryLocation",

+ IDS_SETTINGS_SITE_SETTINGS_LOCATION);

+ html_source->AddLocalizedString("siteSettingsCategoryJavascript",

+ IDS_SETTINGS_SITE_SETTINGS_JAVASCRIPT);

+ html_source->AddLocalizedString("siteSettingsCategoryMicrophone",

+ IDS_SETTINGS_SITE_SETTINGS_MIC);

+ html_source->AddLocalizedString("siteSettingsCategoryNotifications",

+ IDS_SETTINGS_SITE_SETTINGS_NOTIFICATIONS);

+ html_source->AddLocalizedString("siteSettingsCategoryPopups",

+ IDS_SETTINGS_SITE_SETTINGS_POPUPS);

html_source->AddLocalizedString("siteSettingsSiteDetailsPageTitle",

IDS_SETTINGS_SITE_SETTINGS_SITE_DETAILS);

html_source->AddLocalizedString("siteSettingsAllSites",