Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2375)

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.js

Issue 1546993003: Site Settings: Give each category its own route. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.js
diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
index b7375408644a0efd290c591fdf379216a97d2628..17ab458cd36d0a8afc92fed7dd392ee6260d00c5 100644
--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
@@ -39,14 +39,6 @@ Polymer({
type: Object,
notify: true,
},
-
- /**
- * The category selected by the user.
- */
- categorySelected: {
- type: Number,
- notify: true,
- },
},
ready: function() {
@@ -59,7 +51,7 @@ Polymer({
this.addCategory(settings.ContentSettingsTypes.JAVASCRIPT);
this.addCategory(settings.ContentSettingsTypes.POPUPS);
this.addCategory(settings.ContentSettingsTypes.FULLSCREEN);
- this.addCategory(settings.ContentSettingsTypes.NOTIFICATION);
+ this.addCategory(settings.ContentSettingsTypes.NOTIFICATIONS);
this.addCategory(settings.ContentSettingsTypes.IMAGES);
}.bind(this));
},
@@ -100,12 +92,12 @@ Polymer({
*/
onTapCategory: function(event) {
var description = event.currentTarget.querySelector('.flex').innerText;
- this.categorySelected = this.computeCategoryFromDesc(description);
-
+ var page = this.computeCategoryTextId(
+ this.computeCategoryFromDesc(description));
this.currentRoute = {
page: this.currentRoute.page,
section: 'privacy',
- subpage: ['site-settings', 'site-settings-category'],
+ subpage: ['site-settings', 'site-settings-category-' + page],
};
},
});

Powered by Google App Engine
This is Rietveld 408576698