src/objects-debug.cc - Issue 1546933002: Ensure that all non-stable maps created by Map::AddMissingTransitions() are marked as such.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 1546933002: Ensure that all non-stable maps created by Map::AddMissingTransitions() are marked as such. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressing comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index a05d1e703626b125635e9ce15ea935164545023d..e7ee7eca7731c3fe9593055f4fc2906b7ec1dfd5 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -330,6 +330,8 @@ void Map::MapVerify() {

CHECK(instance_size() == kVariableSizeSentinel ||

(kPointerSize <= instance_size() &&

instance_size() < heap->Capacity()));

+ CHECK(GetBackPointer()->IsUndefined() ||

+ !Map::cast(GetBackPointer())->is_stable());

VerifyHeapPointer(prototype());

VerifyHeapPointer(instance_descriptors());

SLOW_DCHECK(instance_descriptors()->IsSortedNoDuplicates());

« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-field-type-tracking.cc » ('j') | no next file with comments »