Source/core/dom/NodeList.cpp - Issue 154693002: Have ChildNodeList subclass NodeList instead of LiveNodeList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/NodeList.cpp

Issue 154693002: Have ChildNodeList subclass NodeList instead of LiveNodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update copyright Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/NodeList.cpp

diff --git a/Source/core/dom/NodeList.cpp b/Source/core/dom/NodeList.cpp

index 689b06fe47c33422dd66b4136855b0d03f62d114..efd9564e7d9538348b4bf475c6ea4c05dc3de69a 100644

--- a/Source/core/dom/NodeList.cpp

+++ b/Source/core/dom/NodeList.cpp

@@ -31,6 +31,7 @@

#include "config.h"

#include "core/dom/NodeList.h"

+#include "core/dom/ChildNodeList.h"

#include "core/dom/EmptyNodeList.h"

#include "core/dom/LiveNodeList.h"

#include "core/dom/Node.h"

@@ -41,6 +42,8 @@ Node* NodeList::ownerNode() const

{

if (isLiveNodeList())

return static_cast<const LiveNodeList*>(this)->ownerNode();

+ if (isChildNodeList())

+ return static_cast<const ChildNodeList*>(this)->ownerNode();

if (isEmptyNodeList())

return static_cast<const EmptyNodeList*>(this)->ownerNode();

return 0;

« no previous file with comments | « Source/core/dom/LiveNodeList.h ('k') | Source/core/html/CollectionType.h » ('j') | no next file with comments »