Have ChildNodeList subclass NodeList instead of LiveNodeList

Source/core/dom/NodeList.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/dom/NodeList.h"
 
+#include "core/dom/ChildNodeList.h"
 #include "core/dom/EmptyNodeList.h"
 #include "core/dom/LiveNodeList.h"
 #include "core/dom/Node.h"
 
 namespace WebCore {
 
 Node* NodeList::ownerNode() const

[adamk, 2014/02/05 19:25:26]

Why isn't this just virtual with a default implementation that returns null?
Instead it does three virtual calls...

[Inactive, 2014/02/05 19:52:48]

Seems to make sense. I remember I added this method to get rid of the custom
bindings for NodeList's visitDOMWrapper. However, I don't remember why I did not
make this virtual. Then again, when I did this there was only 1 virtual call so
it didn't look as bad :)

I will take care of this in a follow-up patch if you don't mind.

[adamk, 2014/02/05 20:32:46]

Sure, a followup patch sounds fine. And I realize that there only used to be a
single isLiveNodeList() check here.

 {
     if (isLiveNodeList())
         return static_cast<const LiveNodeList*>(this)->ownerNode();
+    if (isChildNodeList())
+        return static_cast<const ChildNodeList*>(this)->ownerNode();
     if (isEmptyNodeList())
         return static_cast<const EmptyNodeList*>(this)->ownerNode();
     return 0;
 }
 
 
 } // namespace WebCore