Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1546923002: [Interpreter] Fixes tests for wide bytecodes. (Closed)

Created:
5 years ago by mythria
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fixes tests for wide bytecodes. After this change (https://codereview.chromium.org/1507903004) to type feedback vector, wide bytecodes for global/keyed/named load-stores were not generated due to a change in the number of type feedback vector slots. This cl fixes tests to generate wide bytecodes. BUG=v8:4280 LOG=N Committed: https://crrev.com/6d8979c77944e7924abe791c6addfa4ecf7434dc Cr-Commit-Position: refs/heads/master@{#33076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -135 lines) Patch
M test/cctest/interpreter/test-bytecode-generator.cc View 5 chunks +178 lines, -135 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mythria
PTAL. Thanks, Mythri
5 years ago (2015-12-23 10:46:32 UTC) #2
oth
On 2015/12/23 10:46:32, mythria wrote: > PTAL. > > Thanks, > Mythri lgtm, thanks!
5 years ago (2015-12-23 13:25:02 UTC) #5
Benedikt Meurer
LGTM (rubber-stamped)
4 years, 12 months ago (2015-12-27 07:34:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546923002/1
4 years, 11 months ago (2016-01-04 09:00:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 09:23:18 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 09:24:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d8979c77944e7924abe791c6addfa4ecf7434dc
Cr-Commit-Position: refs/heads/master@{#33076}

Powered by Google App Engine
This is Rietveld 408576698