Type Feedback Vector: Calculate profiler counts on the fly.

Type Feedback Vector: Calculate profiler counts on the fly.

It's cumbersome to maintain IC profiler statistics all the time.
Let's just do it as needed.

BUG=

Committed: https://crrev.com/2b63d6b079540d51489ab38c1d769a842576fe9b
Cr-Commit-Position: refs/heads/master@{#32693}

[mvstanton, 2015-12-08 13:42:02]

mvstanton@chromium.org changed reviewers:
+ bmeurer@chromium.org

[mvstanton, 2015-12-08 13:42:03]

Hi Benedikt,
This looks good enough from a performance perspective to make it a worthwhile
simplification. PTAL, thanks!
--Mike

[Benedikt Meurer, 2015-12-09 07:23:02]

Nice. LGTM once comments are addressed.

https://codereview.chromium.org/1507903004/diff/60001/src/objects-printer.cc
File src/objects-printer.cc (right):

https://codereview.chromium.org/1507903004/diff/60001/src/objects-printer.cc#...
src/objects-printer.cc:600: /*
Nit: Please remove the dead code. We have git for a reason ;-)

https://codereview.chromium.org/1507903004/diff/60001/src/type-feedback-vecto...
File src/type-feedback-vector-inl.h (right):

https://codereview.chromium.org/1507903004/diff/60001/src/type-feedback-vecto...
src/type-feedback-vector-inl.h:109: void TypeFeedbackVector::compute_counts(int*
with_type_info, int* generic) {
ComputeCounts

https://codereview.chromium.org/1507903004/diff/60001/src/type-feedback-vector.h
File src/type-feedback-vector.h (right):

https://codereview.chromium.org/1507903004/diff/60001/src/type-feedback-vecto...
src/type-feedback-vector.h:187: inline void compute_counts(int* with_type_info,
int* generic);
ComputeCounts

[mvstanton, 2015-12-09 07:36:39]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-12-09 07:36:40]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1507903004/#ps80001
(title: "Comment response.")

[commit-bot: I haz the power, 2015-12-09 07:36:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507903004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507903004/80001

[mvstanton, 2015-12-09 07:37:32]

Right on, thanks!

https://codereview.chromium.org/1507903004/diff/60001/src/objects-printer.cc
File src/objects-printer.cc (right):

https://codereview.chromium.org/1507903004/diff/60001/src/objects-printer.cc#...
src/objects-printer.cc:600: /*
On 2015/12/09 07:23:02, Benedikt Meurer wrote:
> Nit: Please remove the dead code. We have git for a reason ;-)

doh! Done.

https://codereview.chromium.org/1507903004/diff/60001/src/type-feedback-vecto...
File src/type-feedback-vector-inl.h (right):

https://codereview.chromium.org/1507903004/diff/60001/src/type-feedback-vecto...
src/type-feedback-vector-inl.h:109: void TypeFeedbackVector::compute_counts(int*
with_type_info, int* generic) {
On 2015/12/09 07:23:02, Benedikt Meurer wrote:
> ComputeCounts

Done.

https://codereview.chromium.org/1507903004/diff/60001/src/type-feedback-vector.h
File src/type-feedback-vector.h (right):

https://codereview.chromium.org/1507903004/diff/60001/src/type-feedback-vecto...
src/type-feedback-vector.h:187: inline void compute_counts(int* with_type_info,
int* generic);
On 2015/12/09 07:23:02, Benedikt Meurer wrote:
> ComputeCounts

Done.

[commit-bot: I haz the power, 2015-12-09 08:33:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-09 08:33:28]

Description was changed from

==========
Type Feedback Vector: Calculate profiler counts on the fly.

It's cumbersome to maintain IC profiler statistics all the time.
Let's just do it as needed.

BUG=
==========

to

==========
Type Feedback Vector: Calculate profiler counts on the fly.

It's cumbersome to maintain IC profiler statistics all the time.
Let's just do it as needed.

BUG=

Committed: https://crrev.com/2b63d6b079540d51489ab38c1d769a842576fe9b
Cr-Commit-Position: refs/heads/master@{#32693}
==========

[commit-bot: I haz the power, 2015-12-09 08:33:29]

Patchset 5 (id:??) landed as
https://crrev.com/2b63d6b079540d51489ab38c1d769a842576fe9b
Cr-Commit-Position: refs/heads/master@{#32693}