Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1507903004: Type Feedback Vector: Calculate profiler counts on the fly. (Closed)

Created:
5 years ago by mvstanton
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Type Feedback Vector: Calculate profiler counts on the fly. It's cumbersome to maintain IC profiler statistics all the time. Let's just do it as needed. BUG= Committed: https://crrev.com/2b63d6b079540d51489ab38c1d769a842576fe9b Cr-Commit-Position: refs/heads/master@{#32693}

Patch Set 1 #

Patch Set 2 : Repaired json-stringify regression with inline func. #

Patch Set 3 : Cleanup. #

Patch Set 4 : More cleanup. #

Total comments: 6

Patch Set 5 : Comment response. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -424 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M src/ic/ic.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/ic/ic.cc View 1 2 10 chunks +11 lines, -30 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M src/objects-printer.cc View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime-profiler.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M src/type-feedback-vector.h View 1 2 3 4 1 chunk +3 lines, -8 lines 0 comments Download
M src/type-feedback-vector.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 2 3 4 2 chunks +28 lines, -29 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 8 chunks +203 lines, -205 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 2 3 chunks +0 lines, -58 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mvstanton
Hi Benedikt, This looks good enough from a performance perspective to make it a worthwhile ...
5 years ago (2015-12-08 13:42:03 UTC) #2
Benedikt Meurer
Nice. LGTM once comments are addressed. https://codereview.chromium.org/1507903004/diff/60001/src/objects-printer.cc File src/objects-printer.cc (right): https://codereview.chromium.org/1507903004/diff/60001/src/objects-printer.cc#newcode600 src/objects-printer.cc:600: /* Nit: Please ...
5 years ago (2015-12-09 07:23:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507903004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507903004/80001
5 years ago (2015-12-09 07:36:43 UTC) #6
mvstanton
Right on, thanks! https://codereview.chromium.org/1507903004/diff/60001/src/objects-printer.cc File src/objects-printer.cc (right): https://codereview.chromium.org/1507903004/diff/60001/src/objects-printer.cc#newcode600 src/objects-printer.cc:600: /* On 2015/12/09 07:23:02, Benedikt Meurer ...
5 years ago (2015-12-09 07:37:32 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-12-09 08:33:04 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-09 08:33:29 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2b63d6b079540d51489ab38c1d769a842576fe9b
Cr-Commit-Position: refs/heads/master@{#32693}

Powered by Google App Engine
This is Rietveld 408576698