Audit //BUILD.gn to enable more targets on Android

Audit //BUILD.gn to enable more targets on Android

BUG=504082
Committed: https://crrev.com/473155b4395f86d3a8be40f6f67af89e41899d10
Cr-Commit-Position: refs/heads/master@{#367009}

[agrieve, 2015-12-23 21:21:06]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org

[agrieve, 2015-12-23 21:21:07]

☃

[Dirk Pranke, 2015-12-23 21:26:33]

mostly lgtm, with a few nits / questions

https://codereview.chromium.org/1546903003/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1546903003/diff/1/BUILD.gn#oldcode700
BUILD.gn:700: }
we don't need this any more?

https://codereview.chromium.org/1546903003/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1546903003/diff/1/BUILD.gn#newcode438
BUILD.gn:438: "//third_party/libaddressinput:libaddressinput_unittests",
Can you add the TODO back in here to note that we still need to audit these for
mac, ios, and chromeos?

https://codereview.chromium.org/1546903003/diff/1/BUILD.gn#newcode718
BUILD.gn:718: "//blimp:blimp_tests",
I think this'll cause you to add blimp_tests if is_chromecast==true, but that's
probably okay?

[agrieve, 2015-12-28 16:11:40]

https://codereview.chromium.org/1546903003/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1546903003/diff/1/BUILD.gn#oldcode700
BUILD.gn:700: }
On 2015/12/23 21:26:33, Dirk Pranke wrote:
> we don't need this any more?

Put it back.

https://codereview.chromium.org/1546903003/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1546903003/diff/1/BUILD.gn#newcode438
BUILD.gn:438: "//third_party/libaddressinput:libaddressinput_unittests",
On 2015/12/23 21:26:33, Dirk Pranke wrote:
> Can you add the TODO back in here to note that we still need to audit these
for
> mac, ios, and chromeos?

Done.

https://codereview.chromium.org/1546903003/diff/1/BUILD.gn#newcode718
BUILD.gn:718: "//blimp:blimp_tests",
On 2015/12/23 21:26:33, Dirk Pranke wrote:
> I think this'll cause you to add blimp_tests if is_chromecast==true, but
that's
> probably okay?

hmm, good observation. My thinking here was that //blimp should be included
under the same conditions as //blimp:blimp_tests. I don't think either are
relevant to chromecast though, so adding a !is_chromecast here.

[agrieve, 2015-12-28 16:12:08]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-12-28 16:12:08]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1546903003/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2015-12-28 16:12:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546903003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546903003/20001

[commit-bot: I haz the power, 2015-12-28 17:03:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-28 17:03:09]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[agrieve, 2015-12-28 19:17:51]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-12-28 19:17:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1546903003/#ps40001
(title: "fix service_discovery_sniffer")

[commit-bot: I haz the power, 2015-12-28 19:18:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546903003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546903003/40001

[commit-bot: I haz the power, 2015-12-28 20:23:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-28 20:24:00]

Description was changed from

==========
Audit //BUILD.gn to enable more targets on Android

BUG=504082
==========

to

==========
Audit //BUILD.gn to enable more targets on Android

BUG=504082

Committed: https://crrev.com/473155b4395f86d3a8be40f6f67af89e41899d10
Cr-Commit-Position: refs/heads/master@{#367009}
==========

[commit-bot: I haz the power, 2015-12-28 20:24:00]

Patchset 3 (id:??) landed as
https://crrev.com/473155b4395f86d3a8be40f6f67af89e41899d10
Cr-Commit-Position: refs/heads/master@{#367009}