Audit //BUILD.gn to enable more targets on Android

BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is the root build file for GN. GN will start processing by loading this
 # file, and recursively load all dependencies until all dependencies are either
 # resolved or known not to exist (which will cause the build to fail). So if
 # you add a new build file, there must be some path of dependencies from this
 # file to your new one or GN won't know about it.
 
@@ skipping 296 matching lines @@
       ]
     }
 
     if (!is_chromecast) {
       deps += [
         "//android_webview",
         "//chrome/android:chrome_junit_tests",
         "//chrome/android:chrome_public_apk",
         "//chrome/android:chrome_public_test_apk",
         "//chrome/test/chromedriver/test/webview_shell:chromedriver_webview_shell_apk",
+        "//content/shell/android:content_shell_test_apk",
         "//third_party/custom_tabs_client:custom_tabs_client_example_apk",
       ]
     }
 
     if (target_cpu != "x64") {
       deps += [ "//third_party/android_platform:android_relocation_packer_unittests($host_toolchain)" ]
     }
 
     if (has_chrome_android_internal) {
       deps += [ "//clank" ]  # TODO(GYP) ??
@@ skipping 51 matching lines @@
   }
 
   if (is_ios || is_win || (is_linux && !is_chromeos)) {
     deps += [
       "//base:base_i18n_perftests",
       "//base:base_perftests",
       "//google_apis:google_apis_unittests",
     ]
   }
 
-  if (is_win || (is_linux && !is_chromeos)) {
-    # TODO(GYP): Figure out which of these should (and can) build
-    # for android/chromeos/mac/ios.
+  if (is_android || is_win || (is_linux && !is_chromeos)) {
     deps += [
       "//base:build_utf8_validator_tables",
       "//base:check_example",
       "//cc:cc_perftests",
       "//cc/blink:cc_blink_unittests",
-      "//chrome/test:load_library_perf_tests",
-      "//chrome/test:performance_browser_tests",
-      "//chrome/test:sync_performance_tests",
-      "//chrome/test/chromedriver:chromedriver",
-      "//chrome/test/chromedriver:chromedriver_tests",
       "//components:components_perftests",
       "//content/test:content_gl_benchmark",
       "//content/test:content_gl_tests",
-      "//courgette:courgette",
-      "//courgette:courgette_fuzz",
-      "//courgette:courgette_minimal_tool",
-      "//courgette:courgette_unittests",
       "//device:device_unittests",
       "//gin:gin_shell",
       "//gin:gin_unittests",
       "//google_apis/gcm:mcs_probe",
       "//gpu:gl_tests",
       "//gpu:gpu_perftests",
       "//ipc:ipc_perftests",
       "//media:media_perftests",
-      "//net:crash_cache",
-      "//net:crl_set_dump",
-      "//net:dns_fuzz_stub",
       "//net:dump_cache",
-      "//net:gdig",
-      "//net:get_server_time",
-      "//net:net_watcher",  # TODO(GYP): This should be conditional on use_v8_in_net
-      "//net:run_testserver",
-      "//net:stress_cache",
-      "//net:tld_cleanup",
-      "//ppapi:pepper_hash_for_uma",
-      "//ppapi:ppapi_perftests",
       "//sync:run_sync_testserver",
-      "//third_party/angle/src/tests:angle_unittests",
       "//third_party/codesighs:maptsvdifftool",
-      "//third_party/leveldatabase:env_chromium_unittests",
-      "//third_party/libaddressinput:libaddressinput_unittests",
       "//third_party/libphonenumber:libphonenumber_unittests",
       "//ui/compositor:compositor_unittests",
     ]
 
-    if (!is_linux) {
+    if (!is_android) {
+      deps += [
+        "//chrome/test:load_library_perf_tests",
+        "//chrome/test:sync_performance_tests",
+        "//chrome/test/chromedriver:chromedriver",
+        "//chrome/test/chromedriver:chromedriver_tests",
+        "//courgette:courgette",
+        "//courgette:courgette_fuzz",
+        "//courgette:courgette_minimal_tool",
+        "//courgette:courgette_unittests",
+        "//media/cast:generate_barcode_video",
+        "//media/cast:generate_timecode_audio",
+        "//net:crash_cache",
+        "//net:crl_set_dump",
+        "//net:dns_fuzz_stub",
+        "//net:gdig",
+        "//net:get_server_time",
+        "//net:net_watcher",  # TODO(GYP): This should be conditional on use_v8_in_net
+        "//net:run_testserver",
+        "//net:stress_cache",
+        "//net:tld_cleanup",
+        "//ppapi:pepper_hash_for_uma",
+        "//ppapi:ppapi_perftests",
+        "//third_party/angle/src/tests:angle_unittests",
+        "//third_party/leveldatabase:env_chromium_unittests",
+        "//third_party/libaddressinput:libaddressinput_unittests",

[Dirk Pranke, 2015/12/23 21:26:33]

Can you add the TODO back in here to note that we still need to audit these for
mac, ios, and chromeos?

[agrieve, 2015/12/28 16:11:40]

Done.

+      ]
+    }
+    if (!is_android && !is_linux) {
       # TODO(dpranke): Re-enable this once
       # https://chromium-review.googlesource.com/#/c/312298/1 is rolled
       # into chromium.
       deps += [ "//third_party/angle/src/tests:angle_end2end_tests" ]
     }
 
     if (enable_extensions) {
       deps += [ "//extensions/shell:app_shell" ]
     }
 
@@ skipping 23 matching lines @@
 
     if (use_aura) {
       deps += [
         "//ui/aura:aura_unittests",
         "//ui/aura:bench",
         "//ui/aura:demo",
       ]
     }
   }
 
-  if (is_linux && !is_chromeos) {
+  if (is_android || (is_linux && !is_chromeos)) {
     deps += [
       # TODO(GYP): Figure out which of these should (and can) build
       # under which other conditions.
-      "//build/sanitizers:copy_llvm_symbolizer",
-      "//chrome/test:chrome_app_unittests",
+      "//breakpad:dump_syms($host_toolchain)",
+      "//breakpad:microdump_stackwalk($host_toolchain)",
+      "//breakpad:minidump_dump($host_toolchain)",
+      "//breakpad:minidump_stackwalk($host_toolchain)",
       "//cloud_print:cloud_print_unittests",
       "//components/network_hints/browser",
       "//content/public/app:browser",
       "//content/public/app:child",
 
       # TODO(GYP): Remove this when the gles2 tests work
       "//gpu/command_buffer/client:gles2_implementation_no_check",
       "//gpu/khronos_glcts_support:khronos_glcts_test",  # TODO(GYP) crbug.com/471903 to make this complete.
-      "//media/cast:tap_proxy",
-      "//media/cast:testing_tools",
       "//mojo/application/public/cpp",
-      "//skia:filter_fuzz_stub",
-      "//skia:image_operations_bench",
-      "//sync/tools:sync_client",
-      "//sync/tools:sync_listen_notifications",
       "//testing/gmock:gmock_main",
 
       # TODO(use-new-edk):
       #"//mojo/edk/test:mojo_public_system_perftests",
       "//third_party/codesighs:nm2tsv",
       "//third_party/mojo/src/mojo/edk/test:mojo_public_system_perftests",
-      "//third_party/sqlite:sqlite_shell",
-      "//ui/keyboard:keyboard_unittests",
-      "//ui/message_center:message_center_unittests",
-      "//ui/snapshot:snapshot_unittests",
-      "//ui/views/examples:views_examples_with_content_exe",
     ]
 
-    deps += [
-      "//breakpad:dump_syms($host_toolchain)",
-      "//breakpad:microdump_stackwalk($host_toolchain)",
-      "//breakpad:minidump_dump($host_toolchain)",
-      "//breakpad:minidump_stackwalk($host_toolchain)",
-    ]
+    if (!is_android) {
+      deps += [
+        "//build/sanitizers:copy_llvm_symbolizer",
+        "//chrome/test:chrome_app_unittests",
+        "//media/cast:cast_benchmarks",
+        "//media/cast:tap_proxy",
+        "//skia:filter_fuzz_stub",
+        "//skia:image_operations_bench",
+        "//sync/tools:sync_client",
+        "//sync/tools:sync_listen_notifications",
+        "//third_party/sqlite:sqlite_shell",
+        "//ui/keyboard:keyboard_unittests",
+        "//ui/message_center:message_center_unittests",
+        "//ui/snapshot:snapshot_unittests",
+        "//ui/views/examples:views_examples_with_content_exe",
+      ]
+    }
 
     if (!is_debug && !is_component_build) {
       deps += [ "//chrome/tools/service_discovery_sniffer" ]
     }
 
     if (toolkit_views) {
       deps += [ "//ui/app_list:app_list_demo" ]
     }
 
     if (use_x11) {
@@ skipping 64 matching lines @@
 
 group("gn_only") {
   testonly = true
 
   deps = []
 
   if (!is_ios) {
     deps += [ "//mojo/common:mojo_common_perftests" ]
   }
 
-  if (!is_ios && !is_chromecast) {
+  if (!is_mac && !is_ios && !is_chromecast) {
     deps += [ "//mandoline:all" ]
   }
 
   if (!is_android && !is_ios && !is_chromeos) {
     deps += [ "//components/proximity_auth:proximity_auth_unittests" ]
   }
 
   if (is_win || is_linux) {
     deps += [ "//mash:all" ]
   }
 
   if (is_linux && !is_chromeos && !is_chromecast) {
     # TODO(GYP): Figure out if any of these should be in gn_all
     # and figure out how cross-platform they are
     deps += [
       ":gn_mojo_targets",
-      "//blimp:blimp_tests",
       "//chrome/browser/resources:extension_resource_demo",
       "//chrome/installer/util:strings",
-      "//chrome/test:load_library_perf_tests",
       "//chrome/tools/convert_dict",
       "//components/constrained_window:unit_tests",
       "//components/enhanced_bookmarks:test_support",
       "//components/metrics:serialization",
       "//components/password_manager/content/renderer:browser_tests",
       "//components/rappor:unit_tests",
       "//components/sessions:unit_tests",
       "//media/blink:media_blink_unittests",
       "//media/cast:udp_proxy",
       "//native_client/src/trusted/debug_stub:gdb_rsp_unittest",
@@ skipping 41 matching lines @@
       "//third_party/opus:test_opus_padding",
       "//third_party/pdfium/third_party:fx_freetype",
       "//third_party/webrtc/system_wrappers:field_trial_default",
       "//third_party/webrtc/system_wrappers:metrics_default",
       "//ui/display/types",
       "//ui/shell_dialogs:shell_dialogs_unittests",
       "//ui/views/examples:views_examples_exe",
     ]
 
     if (target_cpu == "x86" || target_cpu == "x64") {
+      if (!is_android) {
+        deps += [ "//chrome/test:load_library_perf_tests" ]
+      }
       deps += [
         "//native_client/src/trusted/platform_qualify:vcpuid",
         "//third_party/libjpeg_turbo:simd_asm",
       ]
     }
     if (enable_nacl) {
       deps += [ "//native_client/src/trusted/service_runtime:sel_ldr" ]
     }
     if (use_ozone) {
       deps += [ "//ui/ozone/demo" ]
     }
-    if (is_android) {
-      deps += [ "//build/android/gyp/test:hello_world" ]
-    }

[Dirk Pranke, 2015/12/23 21:26:33]

we don't need this any more?

[agrieve, 2015/12/28 16:11:40]

Put it back.

 
     if (is_linux && current_toolchain == host_toolchain) {
       deps += [ "//v8:d8" ]
     }
   }
 
-  if (is_android || is_linux || is_chromeos) {
-    deps += [ "//blimp" ]
+  if (is_android) {
+    deps += [ "//build/android/incremental_install:bootstrap_java" ]
   }
 
-  if (is_mac) {
-    deps -= [ "//mandoline:all" ]  # TODO(GYP)
+  if (is_android || is_linux || is_chromeos) {
+    deps += [
+      "//blimp",
+      "//blimp:blimp_tests",

[Dirk Pranke, 2015/12/23 21:26:33]

I think this'll cause you to add blimp_tests if is_chromecast==true, but that's
probably okay?

[agrieve, 2015/12/28 16:11:40]

hmm, good observation. My thinking here was that //blimp should be included
under the same conditions as //blimp:blimp_tests. I don't think either are
relevant to chromecast though, so adding a !is_chromecast here.

+    ]
   }
 
   if (use_libfuzzer || use_drfuzz) {
     # these are needed only for gn to discover build files.
     deps += [
       "//testing/libfuzzer:libfuzzer_main",
       "//testing/libfuzzer/fuzzers:string_to_int_fuzzer",
       "//testing/libfuzzer/tests:libfuzzer_tests",
     ]
   }
@@ skipping 134 matching lines @@
       ]
 
       if (target_cpu == "x86") {
         deps += [ "//chrome/tools/crash_service:crash_service_win64" ]
       }
     } else {
       deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
     }
   }
 }