Add the crash client ID to the uninstall URL params.

Add the crash client ID to the uninstall URL params.

BUG=504370
Committed: https://crrev.com/a8405987528bcd0b517ac3dae23588a460d95ead
Cr-Commit-Position: refs/heads/master@{#369407}

[grt (UTC plus 2), 2015-12-22 21:16:56]

Patchset #1 (id:1) has been deleted

[grt (UTC plus 2), 2015-12-22 21:17:06]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-22 21:17:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546673002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546673002/20001

[grt (UTC plus 2), 2015-12-22 21:19:47]

grt@chromium.org changed reviewers:
+ scottmg@chromium.org

[grt (UTC plus 2), 2015-12-22 21:19:47]

Hi Scott. Does this look like a reasonable way to get the crash client ID for
the uninstall reporting flow? I haven't tested it with a system-level install
yet (where we want to get the ID for Chrome crashes rather than installer
crashes). Thanks for taking an early look.

[commit-bot: I haz the power, 2015-12-22 21:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-22 21:25:15]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scottmg, 2016-01-08 20:16:09]

lgtm

https://codereview.chromium.org/1546673002/diff/20001/chrome/app/chrome_crash...
File chrome/app/chrome_crash_reporter_client.cc (right):

https://codereview.chromium.org/1546673002/diff/20001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client.cc:283: // In order to be able to start
crash handling very early, we do not rely on
This should probably be moved/duplicated to GetDefaultCrashDumpLocation().

[grt (UTC plus 2), 2016-01-13 18:25:02]

Description was changed from

==========
Add the crash client ID to the uninstall URL params.

BUG=504370
==========

to

==========
Add the crash client ID to the uninstall URL params.

BUG=504370
==========

[grt (UTC plus 2), 2016-01-13 18:25:02]

grt@chromium.org changed reviewers:
+ thakis@chromium.org

[grt (UTC plus 2), 2016-01-13 19:03:56]

Thanks, Scott.

Nico: please take a look at the changes in chrome/common.

https://codereview.chromium.org/1546673002/diff/20001/chrome/app/chrome_crash...
File chrome/app/chrome_crash_reporter_client.cc (right):

https://codereview.chromium.org/1546673002/diff/20001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client.cc:283: // In order to be able to start
crash handling very early, we do not rely on
On 2016/01/08 20:16:09, scottmg wrote:
> This should probably be moved/duplicated to GetDefaultCrashDumpLocation().

Done.

[grt (UTC plus 2), 2016-01-13 19:05:20]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-13 19:05:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546673002/60001

[commit-bot: I haz the power, 2016-01-13 19:16:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 19:16:51]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[grt (UTC plus 2), 2016-01-13 19:32:02]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-13 19:33:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546673002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546673002/80001

[commit-bot: I haz the power, 2016-01-13 20:15:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 20:15:33]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-01-13 21:36:29]

https://codereview.chromium.org/1546673002/diff/80001/chrome/common/chrome_pa...
File chrome/common/chrome_paths_win.cc (right):

https://codereview.chromium.org/1546673002/diff/80001/chrome/common/chrome_pa...
chrome/common/chrome_paths_win.cc:122: // In order to be able to start crash
handling very early, we do not rely on
shouldn't this have an #if defined(OS_WIN) too?

[grt (UTC plus 2), 2016-01-14 01:44:41]

Thanks for taking a look.

https://codereview.chromium.org/1546673002/diff/80001/chrome/common/chrome_pa...
File chrome/common/chrome_paths_win.cc (right):

https://codereview.chromium.org/1546673002/diff/80001/chrome/common/chrome_pa...
chrome/common/chrome_paths_win.cc:122: // In order to be able to start crash
handling very early, we do not rely on
On 2016/01/13 21:36:29, Nico wrote:
> shouldn't this have an #if defined(OS_WIN) too?

It's inherently OS_WIN on account of it being in a _win.cc file.

[Nico, 2016-01-14 03:03:01]

Common lgtm then

[grt (UTC plus 2), 2016-01-14 14:08:26]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2016-01-14 14:08:27]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1546673002/#ps80001
(title: "GN build fix")

[commit-bot: I haz the power, 2016-01-14 14:08:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546673002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546673002/80001

[commit-bot: I haz the power, 2016-01-14 14:12:58]

Description was changed from

==========
Add the crash client ID to the uninstall URL params.

BUG=504370
==========

to

==========
Add the crash client ID to the uninstall URL params.

BUG=504370
==========

[commit-bot: I haz the power, 2016-01-14 14:12:59]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-01-14 14:15:13]

Description was changed from

==========
Add the crash client ID to the uninstall URL params.

BUG=504370
==========

to

==========
Add the crash client ID to the uninstall URL params.

BUG=504370

Committed: https://crrev.com/a8405987528bcd0b517ac3dae23588a460d95ead
Cr-Commit-Position: refs/heads/master@{#369407}
==========

[commit-bot: I haz the power, 2016-01-14 14:15:13]

Patchset 4 (id:??) landed as
https://crrev.com/a8405987528bcd0b517ac3dae23588a460d95ead
Cr-Commit-Position: refs/heads/master@{#369407}