Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1901)

Unified Diff: chrome/common/chrome_paths_win.cc

Issue 1546673002: Add the crash client ID to the uninstall URL params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: GN build fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_paths_internal.h ('k') | chrome/installer/util/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_paths_win.cc
diff --git a/chrome/common/chrome_paths_win.cc b/chrome/common/chrome_paths_win.cc
index 78d357307d0b43c77344d9c32733dac6c2a88ae0..37a262c486d82634261b87ec74ac4eb36c5f6d2c 100644
--- a/chrome/common/chrome_paths_win.cc
+++ b/chrome/common/chrome_paths_win.cc
@@ -118,4 +118,14 @@ bool ProcessNeedsProfileDir(const std::string& process_type) {
return false;
}
+bool GetDefaultCrashDumpLocation(base::FilePath* crash_dir) {
+ // In order to be able to start crash handling very early, we do not rely on
Nico 2016/01/13 21:36:29 shouldn't this have an #if defined(OS_WIN) too?
grt (UTC plus 2) 2016/01/14 01:44:41 It's inherently OS_WIN on account of it being in a
+ // chrome's PathService entries (for DIR_CRASH_DUMPS) being available on
+ // Windows. See https://crbug.com/564398.
+ if (!GetDefaultUserDataDirectory(crash_dir))
+ return false;
+ *crash_dir = crash_dir->Append(FILE_PATH_LITERAL("Crashpad"));
+ return true;
+}
+
} // namespace chrome
« no previous file with comments | « chrome/common/chrome_paths_internal.h ('k') | chrome/installer/util/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698