Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef REMOTING_BASE_BREAKPAD_H_ | 5 #ifndef CHROME_ELF_BREAKPAD_H_ |
| 6 #define REMOTING_BASE_BREAKPAD_H_ | 6 #define CHROME_ELF_BREAKPAD_H_ |
| 7 | 7 |
| 8 namespace remoting { | 8 #include <windows.h> |
| 9 | |
| 10 #include "breakpad/src/client/windows/handler/exception_handler.h" | |
| 9 | 11 |
| 10 // Initializes collection and upload of crash reports. The caller has to ensure | 12 // Initializes collection and upload of crash reports. The caller has to ensure |
| 11 // that the user has agreed to crash dump reporting. | 13 // that the user has agreed to crash dump reporting. |
| 12 // | 14 // |
| 13 // Crash reporting has to be initialized as early as possible (e.g. the first | 15 // Crash reporting has to be initialized as early as possible (e.g. the first |
| 14 // thing in main()) to catch crashes occuring during process startup. | 16 // thing in main()) to catch crashes occuring during process startup. |
| 15 // Crashes which occur during the global static construction phase will not | 17 // Crashes which occur during the global static construction phase will not |
| 16 // be caught and reported. This should not be a problem as static non-POD | 18 // be caught and reported. This should not be a problem as static non-POD |
| 17 // objects are not allowed by the style guide and exceptions to this rule are | 19 // objects are not allowed by the style guide and exceptions to this rule are |
| 18 // rare. | 20 // rare. |
| 19 void InitializeCrashReporting(); | 21 void InitializeCrashReporting(); |
| 20 | 22 |
| 21 } // remoting | 23 int GenerateCrashDump(EXCEPTION_POINTERS* exinfo); |
|
robertshield
2014/02/07 20:03:08
comments on this and the global var below?
Cait (Slow)
2014/02/10 18:13:20
Done.
| |
| 22 | 24 |
| 23 #endif // REMOTING_BASE_BREAKPAD_H_ | 25 extern google_breakpad::ExceptionHandler* g_elf_breakpad; |
| 26 | |
| 27 #endif // CHROME_ELF_BREAKPAD_H_ | |
| OLD | NEW |