Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: chrome_elf/breakpad.h

Issue 154653002: Breakpad coverage for chrome_elf start up (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More breakpad, less base Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_elf/breakpad.h
diff --git a/remoting/base/breakpad.h b/chrome_elf/breakpad.h
similarity index 63%
copy from remoting/base/breakpad.h
copy to chrome_elf/breakpad.h
index 5d81eb52ef0417fb3fcac1962af7f650dbaa5a14..cc5005a89707465d62c5fe469c8fe341620430c6 100644
--- a/remoting/base/breakpad.h
+++ b/chrome_elf/breakpad.h
@@ -1,23 +1,27 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef REMOTING_BASE_BREAKPAD_H_
-#define REMOTING_BASE_BREAKPAD_H_
-
-namespace remoting {
-
-// Initializes collection and upload of crash reports. The caller has to ensure
-// that the user has agreed to crash dump reporting.
-//
-// Crash reporting has to be initialized as early as possible (e.g. the first
-// thing in main()) to catch crashes occuring during process startup.
-// Crashes which occur during the global static construction phase will not
-// be caught and reported. This should not be a problem as static non-POD
-// objects are not allowed by the style guide and exceptions to this rule are
-// rare.
-void InitializeCrashReporting();
-
-} // remoting
-
-#endif // REMOTING_BASE_BREAKPAD_H_
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_ELF_BREAKPAD_H_
+#define CHROME_ELF_BREAKPAD_H_
+
+#include <windows.h>
+
+#include "breakpad/src/client/windows/handler/exception_handler.h"
+
+// Initializes collection and upload of crash reports. The caller has to ensure
+// that the user has agreed to crash dump reporting.
+//
+// Crash reporting has to be initialized as early as possible (e.g. the first
+// thing in main()) to catch crashes occuring during process startup.
+// Crashes which occur during the global static construction phase will not
+// be caught and reported. This should not be a problem as static non-POD
+// objects are not allowed by the style guide and exceptions to this rule are
+// rare.
+void InitializeCrashReporting();
+
+int GenerateCrashDump(EXCEPTION_POINTERS* exinfo);
robertshield 2014/02/07 20:03:08 comments on this and the global var below?
Cait (Slow) 2014/02/10 18:13:20 Done.
+
+extern google_breakpad::ExceptionHandler* g_elf_breakpad;
+
+#endif // CHROME_ELF_BREAKPAD_H_

Powered by Google App Engine
This is Rietveld 408576698