Conditionally set CREATE_BREAKAWAY_FROM_JOB when job objects are used.

This bit of code was added in 2010 by commit 66ae36fec ("Restricting
lifetime of python sync server on Windows via a JobObject"). The
rationale at the time was that running a test case under a debugger
would associate all new processes with the debugger's job object.

Since 2010, Windows 8 and others have been releases, all of which
support nested jobs and do not require processes to be created with the
CREATE_BREAKAWAY_FROM_JOB. Not only that, but unconditionally setting
that flag prevents browser tests from the Windows Task Scheduler at
least on Windows 8 and later: the Task Scheduler creates a job object to
launch the test(s), and calling CreateProcess() with that flag resulted
in an access denied error (error number 5). Not setting it allows
children processes to be created and attached to new job objects in
addition to the Task Scheduler one.

TEST=interactive_ui_tests, content_browsertests from the Windows Task Scheduler (set the task to only run when the user is logged in, otherwise the processes are launched from session 0)
R=phajdan.jr@chromium.org,scottmg@chromium.org,maruel@chromium.org,mark@chromium.org

Committed: https://crrev.com/7db06605487dac6489f1248db2f1e3021477262a
Cr-Commit-Position: refs/heads/master@{#367897}

[Raphael Kubo da Costa (rakuco), 2016-01-04 13:50:15]

Description was changed from

==========
WIP: do not always create processes with CREATE_BREAKAWAY_FROM_JOB.
==========

to

==========
This bit of code was added in 2010 by commit 66ae36fec ("Restricting
lifetime of python sync server on Windows via a JobObject"). The
rationale at the time was that running a test case under a debugger
would associate all new processes with the debugger's job object.

Since 2010, Windows 8 and others have been releases, all of which
support nested jobs and do not require processes to be created with the
CREATE_BREAKAWAY_FROM_JOB. Not only that, but unconditionally setting
that flag prevents browser tests from the Windows Task Scheduler at
least on Windows 8 and later: the Task Scheduler creates a job object to
launch the test(s), and calling CreateProcess() with that flag resulted
in an access denied error (error number 5). Not setting it allows
children processes to be created and attached to new job objects in
addition to the Task Scheduler one.

TEST=interactive_ui_tests, content_browsertests from the Windows Task Scheduler
(set the task to only run when the user is logged in, otherwise the processes
are launched from session 0)
R=phajdan.jr@chromium.org,scottmg@chromium.org,maruel@chromium.org,mark@chrom...
==========

[Raphael Kubo da Costa (rakuco), 2016-01-04 13:51:20]

raphael.kubo.da.costa@intel.com changed reviewers:
+ cpu@chromium.org, mark@chromium.org, maruel@chromium.org,
phajdan.jr@chromium.org, scottmg@chromium.org

[Raphael Kubo da Costa (rakuco), 2016-01-04 13:51:48]

PTAL. This was originally discussed here:
https://groups.google.com/a/chromium.org/d/msg/infra-dev/uQ0JUVktgxA/tukvyPOF...

[cpu_(ooo_6.6-7.5), 2016-01-06 17:32:37]

lgtm

[Raphael Kubo da Costa (rakuco), 2016-01-06 19:41:31]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2016-01-06 19:43:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546313002/20001

[commit-bot: I haz the power, 2016-01-06 20:38:33]

Description was changed from

==========
This bit of code was added in 2010 by commit 66ae36fec ("Restricting
lifetime of python sync server on Windows via a JobObject"). The
rationale at the time was that running a test case under a debugger
would associate all new processes with the debugger's job object.

Since 2010, Windows 8 and others have been releases, all of which
support nested jobs and do not require processes to be created with the
CREATE_BREAKAWAY_FROM_JOB. Not only that, but unconditionally setting
that flag prevents browser tests from the Windows Task Scheduler at
least on Windows 8 and later: the Task Scheduler creates a job object to
launch the test(s), and calling CreateProcess() with that flag resulted
in an access denied error (error number 5). Not setting it allows
children processes to be created and attached to new job objects in
addition to the Task Scheduler one.

TEST=interactive_ui_tests, content_browsertests from the Windows Task Scheduler
(set the task to only run when the user is logged in, otherwise the processes
are launched from session 0)
R=phajdan.jr@chromium.org,scottmg@chromium.org,maruel@chromium.org,mark@chrom...
==========

to

==========
This bit of code was added in 2010 by commit 66ae36fec ("Restricting
lifetime of python sync server on Windows via a JobObject"). The
rationale at the time was that running a test case under a debugger
would associate all new processes with the debugger's job object.

Since 2010, Windows 8 and others have been releases, all of which
support nested jobs and do not require processes to be created with the
CREATE_BREAKAWAY_FROM_JOB. Not only that, but unconditionally setting
that flag prevents browser tests from the Windows Task Scheduler at
least on Windows 8 and later: the Task Scheduler creates a job object to
launch the test(s), and calling CreateProcess() with that flag resulted
in an access denied error (error number 5). Not setting it allows
children processes to be created and attached to new job objects in
addition to the Task Scheduler one.

TEST=interactive_ui_tests, content_browsertests from the Windows Task Scheduler
(set the task to only run when the user is logged in, otherwise the processes
are launched from session 0)
R=phajdan.jr@chromium.org,scottmg@chromium.org,maruel@chromium.org,mark@chrom...
==========

[commit-bot: I haz the power, 2016-01-06 20:38:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-06 20:40:00]

Description was changed from

==========
This bit of code was added in 2010 by commit 66ae36fec ("Restricting
lifetime of python sync server on Windows via a JobObject"). The
rationale at the time was that running a test case under a debugger
would associate all new processes with the debugger's job object.

Since 2010, Windows 8 and others have been releases, all of which
support nested jobs and do not require processes to be created with the
CREATE_BREAKAWAY_FROM_JOB. Not only that, but unconditionally setting
that flag prevents browser tests from the Windows Task Scheduler at
least on Windows 8 and later: the Task Scheduler creates a job object to
launch the test(s), and calling CreateProcess() with that flag resulted
in an access denied error (error number 5). Not setting it allows
children processes to be created and attached to new job objects in
addition to the Task Scheduler one.

TEST=interactive_ui_tests, content_browsertests from the Windows Task Scheduler
(set the task to only run when the user is logged in, otherwise the processes
are launched from session 0)
R=phajdan.jr@chromium.org,scottmg@chromium.org,maruel@chromium.org,mark@chrom...
==========

to

==========
This bit of code was added in 2010 by commit 66ae36fec ("Restricting
lifetime of python sync server on Windows via a JobObject"). The
rationale at the time was that running a test case under a debugger
would associate all new processes with the debugger's job object.

Since 2010, Windows 8 and others have been releases, all of which
support nested jobs and do not require processes to be created with the
CREATE_BREAKAWAY_FROM_JOB. Not only that, but unconditionally setting
that flag prevents browser tests from the Windows Task Scheduler at
least on Windows 8 and later: the Task Scheduler creates a job object to
launch the test(s), and calling CreateProcess() with that flag resulted
in an access denied error (error number 5). Not setting it allows
children processes to be created and attached to new job objects in
addition to the Task Scheduler one.

TEST=interactive_ui_tests, content_browsertests from the Windows Task Scheduler
(set the task to only run when the user is logged in, otherwise the processes
are launched from session 0)
R=phajdan.jr@chromium.org,scottmg@chromium.org,maruel@chromium.org,mark@chrom...

Committed: https://crrev.com/7db06605487dac6489f1248db2f1e3021477262a
Cr-Commit-Position: refs/heads/master@{#367897}
==========

[commit-bot: I haz the power, 2016-01-06 20:40:01]

Patchset 2 (id:??) landed as
https://crrev.com/7db06605487dac6489f1248db2f1e3021477262a
Cr-Commit-Position: refs/heads/master@{#367897}