Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2978)

Unified Diff: base/process/launch_win.cc

Issue 1546313002: Conditionally set CREATE_BREAKAWAY_FROM_JOB when job objects are used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch v2 Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/launch_win.cc
diff --git a/base/process/launch_win.cc b/base/process/launch_win.cc
index 54b06675100431711f837b9d88a74f226f1c92b8..fc38d3a882f6cf31d006a2f455f7860287e18554 100644
--- a/base/process/launch_win.cc
+++ b/base/process/launch_win.cc
@@ -272,8 +272,10 @@ Process LaunchProcess(const string16& cmdline,
// If this code is run under a debugger, the launched process is
// automatically associated with a job object created by the debugger.
- // The CREATE_BREAKAWAY_FROM_JOB flag is used to prevent this.
- flags |= CREATE_BREAKAWAY_FROM_JOB;
+ // The CREATE_BREAKAWAY_FROM_JOB flag is used to prevent this on Windows
+ // releases that do not support nested jobs.
+ if (win::GetVersion() < win::VERSION_WIN8)
+ flags |= CREATE_BREAKAWAY_FROM_JOB;
}
if (options.force_breakaway_from_job_)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698