Command Buffer: add types for vertexAttribPointer against gles3

Command Buffer: add types for vertexAttribPointer against gles3. This change also generates
correct glErrors for vertexAttribPointer and vertexAttribIPointer to fix bugs in command buffer.

BUG=429053
TEST=gpu_unittests

Committed: https://crrev.com/c670faf42a716a6e1d66086b450612bf693aba14
Cr-Commit-Position: refs/heads/master@{#367136}

[yunchao, 2015-12-28 07:53:05]

Description was changed from

==========
add types for vertexAttribPointer against gles3

BUG=429053
==========

to

==========
add types for vertexAttribPointer against gles3

BUG=429053
==========

[yunchao, 2015-12-28 07:53:45]

Description was changed from

==========
add types for vertexAttribPointer against gles3

BUG=429053
==========

to

==========
Command Buffer: add types for vertexAttribPointer against gles3

BUG=429053
==========

[yunchao, 2015-12-28 07:59:35]

Description was changed from

==========
Command Buffer: add types for vertexAttribPointer against gles3

BUG=429053
==========

to

==========
Command Buffer: add types for vertexAttribPointer against gles3

BUG=429053

I came across to see that the types have not been added into VertexAttribPointer
in command buffer. The Blink side code is here:
https://codereview.chromium.org/1537403003/. 

PTAL. Thanks!

BTW, the blink side validation for vertexAttribPointer and vertexAttriIPointer
can be removed after this CL, should we do this? Brandon have filed a crbug to
remove validation in Blink WebGL.
==========

[yunchao, 2015-12-29 12:28:44]

Description was changed from

==========
Command Buffer: add types for vertexAttribPointer against gles3

BUG=429053

I came across to see that the types have not been added into VertexAttribPointer
in command buffer. The Blink side code is here:
https://codereview.chromium.org/1537403003/. 

PTAL. Thanks!

BTW, the blink side validation for vertexAttribPointer and vertexAttriIPointer
can be removed after this CL, should we do this? Brandon have filed a crbug to
remove validation in Blink WebGL.
==========

to

==========
Command Buffer: add types for vertexAttribPointer against gles3

BUG=429053
TEST=gpu_unittests
==========

[yunchao, 2015-12-29 12:28:44]

yunchao.he@intel.com changed reviewers:
+ bajones@chromium.org, kbr@chromium.org, qiankun.miao@intel.com,
zmo@chromium.org

[yunchao, 2015-12-29 12:30:21]

PTAL. Thanks!

BTW, I think that the blink side validation for vertexAttribPointer and
vertexAttriIPointer can be removed after this CL.

[yunchao, 2015-12-29 16:43:31]

On 2015/12/29 12:30:21, yunchao wrote:
> PTAL. Thanks!
> 
> BTW, I think that the blink side validation for vertexAttribPointer and
> vertexAttriIPointer can be removed after this CL.

See this change, in which the validation code is removed:
https://codereview.chromium.org/1555523002/

[Zhenyao Mo, 2015-12-29 21:03:02]

Can you merge this CL with https://codereview.chromium.org/1555523002/?  So we
have more confidence through try bots that the two CLs combined together do not
break anything.

https://codereview.chromium.org/1546303002/diff/1/gpu/command_buffer/common/g...
File gpu/command_buffer/common/gles2_cmd_utils.cc (right):

https://codereview.chromium.org/1546303002/diff/1/gpu/command_buffer/common/g...
gpu/command_buffer/common/gles2_cmd_utils.cc:808: return sizeof(GLushort);  //
NOLINT
nit: wrong indent, here and below.

[yunchao, 2015-12-30 00:35:09]

Thanks for your review, Zhenyao. 

uh... I have considered to merge these two CLs into one last night... I tend to
merge the code to generate correct glError into this one. Then this one fixed
some bugs, and leave another one to be 'only' code-refactoring. 
We make sure that the code is correct before code-refactoring, and it is still
correct after code-refactoring. WDYT?

https://codereview.chromium.org/1546303002/diff/1/gpu/command_buffer/common/g...
File gpu/command_buffer/common/gles2_cmd_utils.cc (right):

https://codereview.chromium.org/1546303002/diff/1/gpu/command_buffer/common/g...
gpu/command_buffer/common/gles2_cmd_utils.cc:808: return sizeof(GLushort);  //
NOLINT
On 2015/12/29 21:03:02, Zhenyao Mo wrote:
> nit: wrong indent, here and below.

Done.

[yunchao, 2015-12-30 00:38:46]

Patchset #2 (id:20001) has been deleted

[Zhenyao Mo, 2015-12-30 00:39:40]

lgtm

[yunchao, 2015-12-30 00:39:42]

Description was changed from

==========
Command Buffer: add types for vertexAttribPointer against gles3

BUG=429053
TEST=gpu_unittests
==========

to

==========
Command Buffer: add types for vertexAttribPointer against gles3. This change
also fixed 
some bugs to generate correct glErrors for these 2 functions in command buffer.

BUG=429053
TEST=gpu_unittests
==========

[yunchao, 2015-12-30 00:41:21]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-30 00:42:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546303002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546303002/40001

[commit-bot: I haz the power, 2015-12-30 01:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-30 01:53:18]

Dry run: This issue passed the CQ dry run.

[yunchao, 2015-12-30 02:27:46]

Description was changed from

==========
Command Buffer: add types for vertexAttribPointer against gles3. This change
also fixed 
some bugs to generate correct glErrors for these 2 functions in command buffer.

BUG=429053
TEST=gpu_unittests
==========

to

==========
Command Buffer: add types for vertexAttribPointer against gles3. This change
also generates 
correct glErrors for vertexAttribPointer and vertexAttribIPointer to fix bugs in
command buffer.

BUG=429053
TEST=gpu_unittests
==========

[yunchao, 2015-12-30 02:28:13]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2015-12-30 02:28:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546303002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546303002/40001

[commit-bot: I haz the power, 2015-12-30 02:33:23]

Description was changed from

==========
Command Buffer: add types for vertexAttribPointer against gles3. This change
also generates 
correct glErrors for vertexAttribPointer and vertexAttribIPointer to fix bugs in
command buffer.

BUG=429053
TEST=gpu_unittests
==========

to

==========
Command Buffer: add types for vertexAttribPointer against gles3. This change
also generates 
correct glErrors for vertexAttribPointer and vertexAttribIPointer to fix bugs in
command buffer.

BUG=429053
TEST=gpu_unittests
==========

[commit-bot: I haz the power, 2015-12-30 02:33:24]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-12-30 02:34:07]

Description was changed from

==========
Command Buffer: add types for vertexAttribPointer against gles3. This change
also generates 
correct glErrors for vertexAttribPointer and vertexAttribIPointer to fix bugs in
command buffer.

BUG=429053
TEST=gpu_unittests
==========

to

==========
Command Buffer: add types for vertexAttribPointer against gles3. This change
also generates
correct glErrors for vertexAttribPointer and vertexAttribIPointer to fix bugs in
command buffer.

BUG=429053
TEST=gpu_unittests

Committed: https://crrev.com/c670faf42a716a6e1d66086b450612bf693aba14
Cr-Commit-Position: refs/heads/master@{#367136}
==========

[commit-bot: I haz the power, 2015-12-30 02:34:07]

Patchset 2 (id:??) landed as
https://crrev.com/c670faf42a716a6e1d66086b450612bf693aba14
Cr-Commit-Position: refs/heads/master@{#367136}