Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1546303002: Command Buffer: add types for vertexAttribPointer against gles3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed zmo@'s feedback: merge some code into this one Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/common/gles2_cmd_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 3e603215a90a762a173ba31ef0904fe74f8bc6f8..e6a08ec9e0e82ef1ee0f16bca11dc6bdd7959722 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -8762,11 +8762,12 @@ error::Error GLES2DecoderImpl::HandleVertexAttribIPointer(
if (state_.vertex_attrib_manager.get() ==
state_.default_vertex_attrib_manager.get()) {
LOCAL_SET_GL_ERROR(
- GL_INVALID_VALUE, "glVertexAttribIPointer", "no array buffer bound");
+ GL_INVALID_OPERATION,
+ "glVertexAttribIPointer", "no array buffer bound");
return error::kNoError;
} else if (c.offset != 0) {
LOCAL_SET_GL_ERROR(
- GL_INVALID_VALUE,
+ GL_INVALID_OPERATION,
"glVertexAttribIPointer", "client side arrays are not allowed");
return error::kNoError;
}
@@ -8848,11 +8849,12 @@ error::Error GLES2DecoderImpl::HandleVertexAttribPointer(
if (state_.vertex_attrib_manager.get() ==
state_.default_vertex_attrib_manager.get()) {
LOCAL_SET_GL_ERROR(
- GL_INVALID_VALUE, "glVertexAttribPointer", "no array buffer bound");
+ GL_INVALID_OPERATION,
+ "glVertexAttribPointer", "no array buffer bound");
return error::kNoError;
} else if (c.offset != 0) {
LOCAL_SET_GL_ERROR(
- GL_INVALID_VALUE,
+ GL_INVALID_OPERATION,
"glVertexAttribPointer", "client side arrays are not allowed");
return error::kNoError;
}
« no previous file with comments | « gpu/command_buffer/common/gles2_cmd_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698