Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 154623002: Stop discarding in frag shader when coverage is zero and stencil writes are enabled (Closed)

Created:
6 years, 10 months ago by bsalomon
Modified:
6 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Stop discarding in frag shader when coverage is zero and stencil writes are enabled This fixes the corruption in the NVPR images here: http://108.170.217.252:10117/builders/Test-Win8-ShuttleA-GTX660-x86-Debug/builds/251/steps/CompareGMs/logs/stdio caused by: https://skia.googlesource.com/skia.git/+/65ee5f424cb4dabd453268902c00086605d77c1d The stencil path step writes inside and outside the clip when the clip is implemented by a coverage effect. The path cover step then doesn't write outside of the clip because the FS discards. This leaves stencil values outside of the clip non-zero which messed up subsequent path or clip draws to those samples. R=robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=13320

Patch Set 1 #

Patch Set 2 : save all the files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M src/gpu/gl/GrGLProgram.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 2 chunks +1 line, -8 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
It's not clear to me why I thought this was necessary. It originates in this ...
6 years, 10 months ago (2014-02-04 22:05:33 UTC) #1
robertphillips
lgtm.
6 years, 10 months ago (2014-02-04 22:33:33 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-05 15:58:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/154623002/30001
6 years, 10 months ago (2014-02-05 15:58:47 UTC) #4
bsalomon
The N10 trybot GM failure is from the ToT code, not this patch.
6 years, 10 months ago (2014-02-05 15:59:20 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 16:29:15 UTC) #6
Message was sent while issue was closed.
Change committed as 13320

Powered by Google App Engine
This is Rietveld 408576698