content/browser/frame_host/frame_tree_node.h - Issue 1545973002: Remove the is_loading_ field from WebContentsImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree_node.h

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Nasko's comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/frame_tree_node.h

diff --git a/content/browser/frame_host/frame_tree_node.h b/content/browser/frame_host/frame_tree_node.h

index df18cf15ee93d96b4e2e3223710f36c974448c19..27a1b030e3bc544b642aa33c11bd847bcc0b3eae 100644

--- a/content/browser/frame_host/frame_tree_node.h

+++ b/content/browser/frame_host/frame_tree_node.h

@@ -236,6 +236,10 @@ class CONTENT_EXPORT FrameTreeNode {

// time and notifies observers.

void DidFocus();

+ // Called when the user closed the modal dialogue for BeforeUnload and

+ // cancelled the navigation. This should stop the loads.

+ void BeforeUnloadCanceled();

private:

class OpenerDestroyedObserver;