content/browser/frame_host/frame_tree.cc - Issue 1545973002: Remove the is_loading_ field from WebContentsImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree.cc

Issue 1545973002: Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Nasko's comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/frame_tree.cc

diff --git a/content/browser/frame_host/frame_tree.cc b/content/browser/frame_host/frame_tree.cc

index e92d28f80be28b571761859cf90da2588917bb5c..c028ab3970d014a11afbc3570826018056930b76 100644

--- a/content/browser/frame_host/frame_tree.cc

+++ b/content/browser/frame_host/frame_tree.cc

@@ -445,7 +445,7 @@ void FrameTree::ResetLoadProgress() {

load_progress_ = 0.0;

}

-bool FrameTree::IsLoading() {

+bool FrameTree::IsLoading() const {

bool is_loading = false;

ForEach(base::Bind(&IsNodeLoading, &is_loading));

return is_loading;