Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2768)

Unified Diff: chrome/installer/setup/BUILD.gn

Issue 1545803002: Use .rc strings in fewer places for installer util. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/gcapi/BUILD.gn ('k') | chrome/installer/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/BUILD.gn
diff --git a/chrome/installer/setup/BUILD.gn b/chrome/installer/setup/BUILD.gn
index e8ec7c5a83646674bf71cd83039554649bac7ef3..ca52311d89d2395fab87ee36e38d3bf20ecf4307 100644
--- a/chrome/installer/setup/BUILD.gn
+++ b/chrome/installer/setup/BUILD.gn
@@ -54,7 +54,7 @@ if (is_win) {
"//base",
"//chrome/common:constants",
"//chrome/common:version_header",
- "//chrome/installer/util",
+ "//chrome/installer/util:with_rc_strings",
"//chrome_elf:constants",
"//components/crash/content/app:app_breakpad_mac_win_to_be_deleted",
"//components/crash/content/app:lib",
@@ -86,8 +86,6 @@ if (is_win) {
"//base/allocator",
"//base/test:test_support",
"//chrome/installer/mini_installer:unit_tests",
- "//chrome/installer/util:strings",
- "//chrome/installer/util:util",
"//testing/gmock",
"//testing/gtest",
]
« no previous file with comments | « chrome/installer/gcapi/BUILD.gn ('k') | chrome/installer/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698