Port android_webview_shell.gyp to GN.

Port android_webview_shell.gyp to GN.

BUG=532905
Committed: https://crrev.com/1a3e9eb8325c618befdd8ec12346c519a8fe2dcd
Cr-Commit-Position: refs/heads/master@{#367037}

[agrieve, 2015-12-22 20:27:57]

🎅

[agrieve, 2015-12-23 20:05:40]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org, michaelbai@chromium.org

[agrieve, 2015-12-23 20:05:41]

dpranke@chromium.org: Please review changes in BUILD.gn

michaelbai@chromium.org: Please review changes in //android_webview

[Dirk Pranke, 2015-12-23 21:20:46]

lgtm.

Do you need to be adding comment lines to the GYP files showing what the
matching GN targets are?

[michaelbai, 2015-12-28 18:47:36]

https://codereview.chromium.org/1545763002/diff/1/android_webview/tools/BUILD.gn
File android_webview/tools/BUILD.gn (right):

https://codereview.chromium.org/1545763002/diff/1/android_webview/tools/BUILD...
android_webview/tools/BUILD.gn:21: DEPRECATED_java_in_dir = "WebViewShell/src"
What's your plan to fix this?

[agrieve, 2015-12-28 19:00:48]

https://codereview.chromium.org/1545763002/diff/1/android_webview/tools/BUILD.gn
File android_webview/tools/BUILD.gn (right):

https://codereview.chromium.org/1545763002/diff/1/android_webview/tools/BUILD...
android_webview/tools/BUILD.gn:21: DEPRECATED_java_in_dir = "WebViewShell/src"
On 2015/12/28 18:47:36, michaelbai wrote:
> What's your plan to fix this?

https://code.google.com/p/chromium/issues/detail?id=484854

[michaelbai, 2015-12-28 19:34:08]

lgtm

https://codereview.chromium.org/1545763002/diff/1/android_webview/tools/BUILD.gn
File android_webview/tools/BUILD.gn (right):

https://codereview.chromium.org/1545763002/diff/1/android_webview/tools/BUILD...
android_webview/tools/BUILD.gn:21: DEPRECATED_java_in_dir = "WebViewShell/src"
On 2015/12/28 19:00:48, agrieve wrote:
> On 2015/12/28 18:47:36, michaelbai wrote:
> > What's your plan to fix this?
> 
> https://code.google.com/p/chromium/issues/detail?id=484854

That's interesting.

[agrieve, 2015-12-29 01:34:22]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-12-29 01:34:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelbai@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1545763002/#ps20001
(title: "add target comments")

[commit-bot: I haz the power, 2015-12-29 01:34:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545763002/20001

[commit-bot: I haz the power, 2015-12-29 02:07:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-29 02:08:26]

Description was changed from

==========
Port android_webview_shell.gyp to GN.

BUG=532905
==========

to

==========
Port android_webview_shell.gyp to GN.

BUG=532905

Committed: https://crrev.com/1a3e9eb8325c618befdd8ec12346c519a8fe2dcd
Cr-Commit-Position: refs/heads/master@{#367037}
==========

[commit-bot: I haz the power, 2015-12-29 02:08:27]

Patchset 2 (id:??) landed as
https://crrev.com/1a3e9eb8325c618befdd8ec12346c519a8fe2dcd
Cr-Commit-Position: refs/heads/master@{#367037}