content/browser/service_worker/service_worker_cache_writer_unittest.cc - Issue 1545243002: Convert Pass()→std::move() in //content/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_cache_writer_unittest.cc

Issue 1545243002: Convert Pass()→std::move() in //content/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_context_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_cache_writer_unittest.cc

diff --git a/content/browser/service_worker/service_worker_cache_writer_unittest.cc b/content/browser/service_worker/service_worker_cache_writer_unittest.cc

index 96f6599cc837b2253683dc6edc5387ac5b1a9978..030411b3dcfb0596bc45406a69573a1b0772a17a 100644

--- a/content/browser/service_worker/service_worker_cache_writer_unittest.cc

+++ b/content/browser/service_worker/service_worker_cache_writer_unittest.cc

@@ -361,14 +361,14 @@ class ServiceWorkerCacheWriterTest : public ::testing::Test {

return make_scoped_ptr<ServiceWorkerResponseReader>(nullptr);

scoped_ptr<ServiceWorkerResponseReader> reader(readers_.front());

readers_.pop_front();

- return reader.Pass();

+ return reader;

}

scoped_ptr<ServiceWorkerResponseWriter> CreateWriter() {

if (writers_.empty())

return make_scoped_ptr<ServiceWorkerResponseWriter>(nullptr);

scoped_ptr<ServiceWorkerResponseWriter> writer(writers_.front());

writers_.pop_front();

- return writer.Pass();

+ return writer;

}

ServiceWorkerCacheWriter::OnWriteCompleteCallback CreateWriteCallback() {