Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: content/browser/service_worker/service_worker_cache_writer_unittest.cc

Issue 1545243002: Convert Pass()→std::move() in //content/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/service_worker_cache_writer.h" 5 #include "content/browser/service_worker/service_worker_cache_writer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <list> 9 #include <list>
10 #include <queue> 10 #include <queue>
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 writers_deleter_; 354 writers_deleter_;
355 scoped_ptr<ServiceWorkerCacheWriter> cache_writer_; 355 scoped_ptr<ServiceWorkerCacheWriter> cache_writer_;
356 bool write_complete_; 356 bool write_complete_;
357 net::Error last_error_; 357 net::Error last_error_;
358 358
359 scoped_ptr<ServiceWorkerResponseReader> CreateReader() { 359 scoped_ptr<ServiceWorkerResponseReader> CreateReader() {
360 if (readers_.empty()) 360 if (readers_.empty())
361 return make_scoped_ptr<ServiceWorkerResponseReader>(nullptr); 361 return make_scoped_ptr<ServiceWorkerResponseReader>(nullptr);
362 scoped_ptr<ServiceWorkerResponseReader> reader(readers_.front()); 362 scoped_ptr<ServiceWorkerResponseReader> reader(readers_.front());
363 readers_.pop_front(); 363 readers_.pop_front();
364 return reader.Pass(); 364 return reader;
365 } 365 }
366 scoped_ptr<ServiceWorkerResponseWriter> CreateWriter() { 366 scoped_ptr<ServiceWorkerResponseWriter> CreateWriter() {
367 if (writers_.empty()) 367 if (writers_.empty())
368 return make_scoped_ptr<ServiceWorkerResponseWriter>(nullptr); 368 return make_scoped_ptr<ServiceWorkerResponseWriter>(nullptr);
369 scoped_ptr<ServiceWorkerResponseWriter> writer(writers_.front()); 369 scoped_ptr<ServiceWorkerResponseWriter> writer(writers_.front());
370 writers_.pop_front(); 370 writers_.pop_front();
371 return writer.Pass(); 371 return writer;
372 } 372 }
373 373
374 ServiceWorkerCacheWriter::OnWriteCompleteCallback CreateWriteCallback() { 374 ServiceWorkerCacheWriter::OnWriteCompleteCallback CreateWriteCallback() {
375 return base::Bind(&ServiceWorkerCacheWriterTest::OnWriteComplete, 375 return base::Bind(&ServiceWorkerCacheWriterTest::OnWriteComplete,
376 base::Unretained(this)); 376 base::Unretained(this));
377 } 377 }
378 378
379 void OnWriteComplete(net::Error error) { 379 void OnWriteComplete(net::Error error) {
380 write_complete_ = true; 380 write_complete_ = true;
381 last_error_ = error; 381 last_error_ = error;
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
800 error = WriteData(""); 800 error = WriteData("");
801 EXPECT_EQ(net::OK, error); 801 EXPECT_EQ(net::OK, error);
802 802
803 EXPECT_TRUE(writer->AllExpectedWritesDone()); 803 EXPECT_TRUE(writer->AllExpectedWritesDone());
804 EXPECT_TRUE(compare_reader->AllExpectedReadsDone()); 804 EXPECT_TRUE(compare_reader->AllExpectedReadsDone());
805 EXPECT_TRUE(copy_reader->AllExpectedReadsDone()); 805 EXPECT_TRUE(copy_reader->AllExpectedReadsDone());
806 } 806 }
807 807
808 } // namespace 808 } // namespace
809 } // namespace content 809 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698