Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1545183002: Merge to XFA: Switch from nonstd::unique_ptr to std::unique_ptr. (Closed)

Created:
4 years, 12 months ago by Lei Zhang
Modified:
4 years, 12 months ago
Reviewers:
Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Switch from nonstd::unique_ptr to std::unique_ptr. TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1547833002 . (cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8) Committed: https://pdfium.googlesource.com/pdfium/+/aa8bf7e42b8c73a9bc07ed6781364ba05f5a9776

Patch Set 1 #

Patch Set 2 : xfa #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -1241 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_module.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/include/fxcodec/fx_codec.h View 2 chunks +13 lines, -12 lines 1 comment Download
M core/include/fxcrt/fx_basic.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxge/fx_font.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 15 chunks +15 lines, -15 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 5 chunks +4 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 5 chunks +5 lines, -5 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_bookmark.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 3 chunks +4 lines, -3 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 4 chunks +6 lines, -4 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.h View 3 chunks +6 lines, -6 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.cpp View 22 chunks +40 lines, -40 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GrdProc.cpp View 9 chunks +10 lines, -9 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GrrdProc.cpp View 5 chunks +6 lines, -5 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GsidProc.cpp View 4 chunks +7 lines, -6 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HtrdProc.cpp View 4 chunks +7 lines, -6 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_PddProc.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SddProc.cpp View 15 chunks +56 lines, -62 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_TrdProc.cpp View 6 chunks +8 lines, -7 lines 0 comments Download
M fpdfsdk/include/fsdk_actionhandler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 5 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Object.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime_Stub.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M testing/embedder_test.h View 3 chunks +2 lines, -2 lines 0 comments Download
M testing/js_embedder_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/base/nonstd_unique_ptr.h View 1 chunk +0 lines, -398 lines 0 comments Download
D third_party/base/nonstd_unique_ptr_unittest.cpp View 1 chunk +0 lines, -391 lines 0 comments Download
M third_party/base/numerics/safe_conversions_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/base/numerics/safe_math.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/base/numerics/safe_math_impl.h View 18 chunks +57 lines, -54 lines 0 comments Download
D third_party/base/template_util.h View 1 chunk +0 lines, -79 lines 0 comments Download
M third_party/third_party.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_datetimepickerimp.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_editimp.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_listboximp.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/barcode.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/caret.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/checkbox.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/combobox.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/datetimepicker.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/edit.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/listbox.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/picturebox.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/pushbutton.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/scrollbar.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/tooltipctrl.cpp View 1 3 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDimWriter.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/src/fxgraphics/src/fx_graphics.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Lei Zhang
TBR Patch set 1 is a clean merge except where noted below. Patch set 2 ...
4 years, 12 months ago (2015-12-25 03:13:28 UTC) #1
Lei Zhang
4 years, 12 months ago (2015-12-25 03:13:38 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
aa8bf7e42b8c73a9bc07ed6781364ba05f5a9776 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698