chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html - Issue 154473002: Support redirectUrl at onHeadersReceived in WebRequest / DWR API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html

Issue 154473002: Support redirectUrl at onHeadersReceived in WebRequest / DWR API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add more tests Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/web_request.json ('k') | chrome/common/extensions/docs/templates/intros/webRequest.html » ('j') | net/http/http_response_headers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html

diff --git a/chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html b/chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html

index bae8a561240cfa3230e3976981a2af551f77db13..32691d0f168a9fca90e197b5168f1f8d12e5f6d6 100644

--- a/chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html

+++ b/chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html

@@ -180,10 +180,10 @@ request stages that are compatible with conditions and actions.

<tr><td>EditRequestCookie<td><td>✓<td><td>

<tr><td>EditResponseCookie<td><td><td>✓<td>

<tr><td>IgnoreRules<td>✓<td>✓<td>✓<td>✓

- <tr><td>RedirectByRegEx<td>✓<td><td><td>

- <tr><td>RedirectRequest<td>✓<td><td><td>

- <tr><td>RedirectToEmptyDocument<td>✓<td><td><td>

- <tr><td>RedirectToTransparentImage<td>✓<td><td><td>

+ <tr><td>RedirectByRegEx<td>✓<td><td>✓<td>

+ <tr><td>RedirectRequest<td>✓<td><td>✓<td>

+ <tr><td>RedirectToEmptyDocument<td>✓<td><td>✓<td>

+ <tr><td>RedirectToTransparentImage<td>✓<td><td>✓<td>

<tr><td>RemoveRequestCookie<td><td>✓<td><td>

<tr><td>RemoveRequestHeader<td><td>✓<td><td>

<tr><td>RemoveResponseCookie<td><td><td>✓<td>

@@ -203,9 +203,8 @@ request stages that are compatible with conditions and actions.

condition with a <code>new chrome.declarativeWebRequest.CancelRequest()</code>

action because both of them can be evaluated in the onHeadersReceived stage.

It is, however, impossible to combine the request matcher with a

-<code>new chrome.declarativeWebRequest.RedirectToTransparentImage()</code>

-because redirects cannot be executed any more by the time the content

-type has been determined.

+<code>new chrome.declarativeWebRequest.SetRequestHeader()</code>

+because request headers cannot be set any more by the time the content type has been terminated.

</p>

<h2 id="precedences">Using priorities to override rules</h2>