chrome/common/extensions/api/web_request.json - Issue 154473002: Support redirectUrl at onHeadersReceived in WebRequest / DWR API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/web_request.json

Issue 154473002: Support redirectUrl at onHeadersReceived in WebRequest / DWR API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add more tests Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api_unittest.cc ('k') | chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html » ('j') | net/http/http_response_headers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/web_request.json

diff --git a/chrome/common/extensions/api/web_request.json b/chrome/common/extensions/api/web_request.json

index 51a161edbf2d57d815afd3e51dfb9d22d0878603..b17e2dfc49ede8f62a2a477d61328eaba7c37870 100644

--- a/chrome/common/extensions/api/web_request.json

+++ b/chrome/common/extensions/api/web_request.json

@@ -66,7 +66,7 @@

"redirectUrl": {

"type": "string",

"optional": true,

- "description": "Only used as a response to the onBeforeRequest event. If set, the original request is prevented from being sent and is instead redirected to the given URL."

+ "description": "Only used as a response to the onBeforeRequest and onHeadersReceived events. If set, the original request is prevented from being sent/completed and is instead redirected to the given URL. Redirections to non-HTTP schemes such as data: are allowed. The request method and request body are preserved during this redirect, so take care to not accidentally forward a sensitive POST request to an untrusted location."

"requestHeaders": {

"$ref": "HttpHeaders",