Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h
diff --git a/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h b/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h
index 85008ba4c212dc5298e59f4875a428e7540bffcb..c5f84271c69564bcc52cb62575bf1df823a4c541 100644
--- a/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h
+++ b/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h
@@ -60,7 +60,7 @@ public:
virtual void setAnimatedValue(PassRefPtrWillBeRawPtr<SVGPropertyBase>) = 0;
virtual void animationEnded();
- virtual void setBaseValueAsString(const String& value, SVGParsingError& parseError) = 0;
+ virtual SVGParsingError setBaseValueAsString(const String&) = 0;
virtual bool needsSynchronizeAttribute() = 0;
virtual void synchronizeAttribute();
@@ -143,14 +143,9 @@ public:
return m_currentValue;
}
- void setBaseValueAsString(const String& value, SVGParsingError& parseError) override
+ SVGParsingError setBaseValueAsString(const String& value) override
{
- TrackExceptionState es;
-
- m_baseValue->setValueAsString(value, es);
-
- if (es.hadException())
- parseError = ParsingAttributeFailedError;
+ return m_baseValue->setValueAsString(value);
}
PassRefPtrWillBeRawPtr<SVGPropertyBase> createAnimatedValue() override

Powered by Google App Engine
This is Rietveld 408576698