Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: third_party/WebKit/Source/core/svg/SVGTransformList.cpp

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGTransformList.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGTransformList.cpp b/third_party/WebKit/Source/core/svg/SVGTransformList.cpp
index 6076f5f404b679817fe978d525c2c4ade3efcbbb..28861bae348674758afc1a018744b62a786b26d2 100644
--- a/third_party/WebKit/Source/core/svg/SVGTransformList.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGTransformList.cpp
@@ -266,11 +266,11 @@ String SVGTransformList::valueAsString() const
return builder.toString();
}
-void SVGTransformList::setValueAsString(const String& value, ExceptionState& exceptionState)
+SVGParsingError SVGTransformList::setValueAsString(const String& value)
{
if (value.isEmpty()) {
clear();
- return;
+ return NoError;
}
bool valid = false;
@@ -286,8 +286,10 @@ void SVGTransformList::setValueAsString(const String& value, ExceptionState& exc
if (!valid) {
clear();
- exceptionState.throwDOMException(SyntaxError, "Problem parsing transform list=\""+value+"\"");
+ return ParsingAttributeFailedError;
}
+
+ return NoError;
}
PassRefPtrWillBeRawPtr<SVGPropertyBase> SVGTransformList::cloneForAnimation(const String& value) const

Powered by Google App Engine
This is Rietveld 408576698