Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: third_party/WebKit/Source/core/svg/SVGNumber.h

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGNumber.h
diff --git a/third_party/WebKit/Source/core/svg/SVGNumber.h b/third_party/WebKit/Source/core/svg/SVGNumber.h
index 4cd1132f2cc3b7cd90c380a2dcc799e9ec68c08b..e83b7152f0ec93607ecf538bbfc6b64df554170e 100644
--- a/third_party/WebKit/Source/core/svg/SVGNumber.h
+++ b/third_party/WebKit/Source/core/svg/SVGNumber.h
@@ -31,7 +31,7 @@
#ifndef SVGNumber_h
#define SVGNumber_h
-#include "bindings/core/v8/ExceptionMessages.h"
+#include "core/svg/SVGParsingError.h"
#include "core/svg/properties/SVGPropertyHelper.h"
namespace blink {
@@ -55,7 +55,7 @@ public:
void setValue(float value) { m_value = value; }
String valueAsString() const override;
- virtual void setValueAsString(const String&, ExceptionState&);
+ virtual SVGParsingError setValueAsString(const String&);
void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement* contextElement) override;
@@ -86,7 +86,7 @@ public:
}
PassRefPtrWillBeRawPtr<SVGNumber> clone() const override;
- void setValueAsString(const String&, ExceptionState&) override;
+ SVGParsingError setValueAsString(const String&) override;
private:
explicit SVGNumberAcceptPercentage(float);

Powered by Google App Engine
This is Rietveld 408576698