Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGNumber.h

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef SVGNumber_h 31 #ifndef SVGNumber_h
32 #define SVGNumber_h 32 #define SVGNumber_h
33 33
34 #include "bindings/core/v8/ExceptionMessages.h" 34 #include "core/svg/SVGParsingError.h"
35 #include "core/svg/properties/SVGPropertyHelper.h" 35 #include "core/svg/properties/SVGPropertyHelper.h"
36 36
37 namespace blink { 37 namespace blink {
38 38
39 class SVGNumberTearOff; 39 class SVGNumberTearOff;
40 40
41 class SVGNumber : public SVGPropertyHelper<SVGNumber> { 41 class SVGNumber : public SVGPropertyHelper<SVGNumber> {
42 public: 42 public:
43 // SVGNumber has a tear-off type, but SVGAnimatedNumber uses primitive type. 43 // SVGNumber has a tear-off type, but SVGAnimatedNumber uses primitive type.
44 typedef SVGNumberTearOff TearOffType; 44 typedef SVGNumberTearOff TearOffType;
45 typedef float PrimitiveType; 45 typedef float PrimitiveType;
46 46
47 static PassRefPtrWillBeRawPtr<SVGNumber> create(float value = 0.0f) 47 static PassRefPtrWillBeRawPtr<SVGNumber> create(float value = 0.0f)
48 { 48 {
49 return adoptRefWillBeNoop(new SVGNumber(value)); 49 return adoptRefWillBeNoop(new SVGNumber(value));
50 } 50 }
51 51
52 virtual PassRefPtrWillBeRawPtr<SVGNumber> clone() const; 52 virtual PassRefPtrWillBeRawPtr<SVGNumber> clone() const;
53 53
54 float value() const { return m_value; } 54 float value() const { return m_value; }
55 void setValue(float value) { m_value = value; } 55 void setValue(float value) { m_value = value; }
56 56
57 String valueAsString() const override; 57 String valueAsString() const override;
58 virtual void setValueAsString(const String&, ExceptionState&); 58 virtual SVGParsingError setValueAsString(const String&);
59 59
60 void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override; 60 void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
61 void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawP tr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDuratio nValue, SVGElement* contextElement) override; 61 void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawP tr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDuratio nValue, SVGElement* contextElement) override;
62 float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGEleme nt* contextElement) override; 62 float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGEleme nt* contextElement) override;
63 63
64 static AnimatedPropertyType classType() { return AnimatedNumber; } 64 static AnimatedPropertyType classType() { return AnimatedNumber; }
65 65
66 protected: 66 protected:
67 explicit SVGNumber(float); 67 explicit SVGNumber(float);
68 68
(...skipping 10 matching lines...) Expand all
79 // Spec: http://www.w3.org/TR/SVG11/pservers.html#GradientStops 79 // Spec: http://www.w3.org/TR/SVG11/pservers.html#GradientStops
80 // offset = "<number> | <percentage>" 80 // offset = "<number> | <percentage>"
81 class SVGNumberAcceptPercentage final : public SVGNumber { 81 class SVGNumberAcceptPercentage final : public SVGNumber {
82 public: 82 public:
83 static PassRefPtrWillBeRawPtr<SVGNumberAcceptPercentage> create(float value = 0) 83 static PassRefPtrWillBeRawPtr<SVGNumberAcceptPercentage> create(float value = 0)
84 { 84 {
85 return adoptRefWillBeNoop(new SVGNumberAcceptPercentage(value)); 85 return adoptRefWillBeNoop(new SVGNumberAcceptPercentage(value));
86 } 86 }
87 87
88 PassRefPtrWillBeRawPtr<SVGNumber> clone() const override; 88 PassRefPtrWillBeRawPtr<SVGNumber> clone() const override;
89 void setValueAsString(const String&, ExceptionState&) override; 89 SVGParsingError setValueAsString(const String&) override;
90 90
91 private: 91 private:
92 explicit SVGNumberAcceptPercentage(float); 92 explicit SVGNumberAcceptPercentage(float);
93 }; 93 };
94 94
95 } // namespace blink 95 } // namespace blink
96 96
97 #endif // SVGNumber_h 97 #endif // SVGNumber_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698