Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: content/browser/download/url_downloader.h

Issue 1544603003: [Downloads] Do not store error responses during resumption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unify-downloader-core
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/url_downloader.h
diff --git a/content/browser/download/url_downloader.h b/content/browser/download/url_downloader.h
index 787feb4c91b35918dbe2ee35f3f089994f2553be..5beaa5895d30ee173828269e460f0decfefa89c7 100644
--- a/content/browser/download/url_downloader.h
+++ b/content/browser/download/url_downloader.h
@@ -17,6 +17,8 @@
#include "net/url_request/url_request.h"
namespace content {
+class ByteStreamReader;
+struct DownloadCreateInfo;
class DownloadManagerImpl;
class UrlDownloader : public net::URLRequest::Delegate {
@@ -60,6 +62,11 @@ class UrlDownloader : public net::URLRequest::Delegate {
void ResumeRequest();
void CancelRequest();
+ // Called when the UrlDownloader is done with the request. Posts a task to
+ // remove itself from its download manager, which in turn would cause the
+ // UrlDownloader to be freed.
+ void Done();
svaldez 2016/01/13 17:29:18 Can we call it Destroy since this doesn't necessar
asanka 2016/01/28 02:24:17 Done.
+
scoped_ptr<net::URLRequest> request_;
base::WeakPtr<DownloadManagerImpl> manager_;
uint32_t download_id_;

Powered by Google App Engine
This is Rietveld 408576698