[Downloads] Do not store error responses during resumption.

content/browser/download/url_downloader.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_URL_DOWNLOADER_H_
 #define CONTENT_BROWSER_DOWNLOAD_URL_DOWNLOADER_H_
 
 #include <stdint.h>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "content/browser/download/download_request_core.h"
 #include "content/public/browser/download_save_info.h"
 #include "content/public/browser/download_url_parameters.h"
 #include "content/public/common/referrer.h"
 #include "net/url_request/redirect_info.h"
 #include "net/url_request/url_request.h"
 
 namespace content {
+class ByteStreamReader;
+struct DownloadCreateInfo;
 class DownloadManagerImpl;
 
 class UrlDownloader : public net::URLRequest::Delegate {
  public:
   UrlDownloader(
       scoped_ptr<net::URLRequest> request,
       base::WeakPtr<DownloadManagerImpl> manager,
       scoped_ptr<DownloadSaveInfo> save_info,
       uint32_t download_id,
       const DownloadUrlParameters::OnStartedCallback& on_started_callback);
@@ skipping 23 matching lines @@
 
   void CallStartedCallbackOnFailure(DownloadInterruptReason result);
 
  private:
   class RequestHandle;
 
   void PauseRequest();
   void ResumeRequest();
   void CancelRequest();
 
+  // Called when the UrlDownloader is done with the request. Posts a task to
+  // remove itself from its download manager, which in turn would cause the
+  // UrlDownloader to be freed.
+  void Done();

[svaldez, 2016/01/13 17:29:18]

Can we call it Destroy since this doesn't necessarily mean the request was
completed.

[asanka, 2016/01/28 02:24:17]

Done.

+
   scoped_ptr<net::URLRequest> request_;
   base::WeakPtr<DownloadManagerImpl> manager_;
   uint32_t download_id_;
   DownloadUrlParameters::OnStartedCallback on_started_callback_;
 
   DownloadRequestCore handler_;
 
   base::WeakPtrFactory<UrlDownloader> weak_ptr_factory_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_URL_DOWNLOADER_H_