Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 154403002: Revert of Enable stack tool and ASan symbolization of logcat on Android bots. (Closed)

Created:
6 years, 10 months ago by navabi
Modified:
6 years, 10 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Revert of Enable stack tool and ASan symbolization of logcat on Android bots. (https://codereview.chromium.org/149503002/) Reason for revert: Sorry, we can not commit this without the accompanying downstream change, because without that there are two --disable-stack-tool option strings (one in the downstream script and the newly added one here). This causes the following error on the clank tot bot: optparse.OptionConflictError: option --disable-stack-tool: conflicting option string(s): --disable-stack-tool Link: https://chromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/22826/steps/compile/logs/stdio Reverting because this is keeping clank from picking up changes, and I'm not sure how to do a quick fix right now. Removing the option from clank requires the public script to have it, which requires clank to roll. Slightly tricky and I don't have the time to do it today. Original issue's description: > Enable stack tool and ASan symbolization of logcat on Android bots. > > BUG=325685 > R=frankf@chromium.org, craigdh@chromium.org, navabi@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248694 TBR=craigdh@chromium.org,frankf@chromium.org,navabi@chromium.org,eugenis@chromium.org NOTREECHECKS=true NOTRY=true BUG=325685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M build/android/buildbot/bb_device_steps.py View 3 chunks +1 line, -23 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
navabi
Created Revert of Enable stack tool and ASan symbolization of logcat on Android bots.
6 years, 10 months ago (2014-02-04 21:16:11 UTC) #1
navabi
6 years, 10 months ago (2014-02-04 21:16:47 UTC) #2
navabi
The CQ bit was unchecked by navabi@google.com
6 years, 10 months ago (2014-02-04 21:24:53 UTC) #3
navabi
The CQ bit was checked by navabi@google.com
6 years, 10 months ago (2014-02-04 21:24:56 UTC) #4
navabi
lgtm not sure why it is not committing.
6 years, 10 months ago (2014-02-04 21:36:18 UTC) #5
navabi
The CQ bit was unchecked by navabi@google.com
6 years, 10 months ago (2014-02-04 21:53:13 UTC) #6
navabi1
The CQ bit was checked by navabi@chromium.org
6 years, 10 months ago (2014-02-04 21:53:27 UTC) #7
navabi1
6 years, 10 months ago (2014-02-04 22:00:37 UTC) #8
The CQ bit was unchecked by navabi@chromium.org

Powered by Google App Engine
This is Rietveld 408576698