Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 154403002: Revert of Enable stack tool and ASan symbolization of logcat on Android bots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/buildbot/bb_run_bot.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index cc4ea22daf8a88cda6eec3c4f6cd01a208a4e0ca..f4e7f8dada4b18abb5dab35ea6e614aa1742e9c1 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -530,23 +530,6 @@
RunCmd(['cat', logcat_file])
-def RunStackToolSteps(options):
- """Run stack tool steps.
-
- Stack tool is run for logcat dump, optionally for ASAN.
- """
- bb_annotations.PrintNamedStep('Run stack tool with logcat dump')
- logcat_file = os.path.join(CHROME_OUT_DIR, options.target, 'full_log')
- RunCmd([os.path.join(CHROME_SRC_DIR, 'third_party', 'android_platform',
- 'development', 'scripts', 'stack'),
- '--more-info', logcat_file])
- if options.asan_symbolize:
- bb_annotations.PrintNamedStep('Run stack tool for ASAN')
- RunCmd([
- os.path.join(CHROME_SRC_DIR, 'build', 'android', 'asan_symbolize.py'),
- '-l', logcat_file])
-
-
def GenerateTestReport(options):
bb_annotations.PrintNamedStep('test_report')
for report in glob.glob(
@@ -583,8 +566,6 @@
finally:
# Run all post test steps
LogcatDump(options)
- if not options.disable_stack_tool:
- RunStackToolSteps(options)
GenerateTestReport(options)
# KillHostHeartbeat() has logic to check if heartbeat process is running,
# and kills only if it finds the process is running on the host.
@@ -621,10 +602,7 @@
parser.add_option(
'--logcat-dump-output',
help='The logcat dump output will be "tee"-ed into this file')
- parser.add_option('--disable-stack-tool', action='store_true',
- help='Do not run stack tool.')
- parser.add_option('--asan-symbolize', action='store_true',
- help='Run stack tool for ASAN')
+
return parser
« no previous file with comments | « no previous file | build/android/buildbot/bb_run_bot.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698