Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1543903002: Adds socket param to OnReadError in QuicPacketReader's Visitor interface. (Closed)

Created:
5 years ago by Jana
Modified:
5 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@home
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds socket param to OnReadError in QuicPacketReader's Visitor interface. (Breaking out connection migration CL https://codereview.chromium.org/1327923002/.) R=rch@chromium.org,pauljensen@chromium.org BUG= Committed: https://crrev.com/d140c475ce37b2c3b2cb6cd1032896b0228bcbbf Cr-Commit-Position: refs/heads/master@{#366689}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M net/quic/quic_chromium_client_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_chromium_client_session.cc View 1 chunk +3 lines, -1 line 1 comment Download
M net/quic/quic_packet_reader.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_packet_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_client.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_client.cc View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Jana
5 years ago (2015-12-22 19:54:58 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/1543903002/diff/1/net/quic/quic_chromium_client_session.cc File net/quic/quic_chromium_client_session.cc (right): https://codereview.chromium.org/1543903002/diff/1/net/quic/quic_chromium_client_session.cc#newcode917 net/quic/quic_chromium_client_session.cc:917: const DatagramClientSocket* socket) { Typically, we would do ...
5 years ago (2015-12-22 22:03:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543903002/1
5 years ago (2015-12-22 22:04:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 23:28:20 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-22 23:30:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d140c475ce37b2c3b2cb6cd1032896b0228bcbbf
Cr-Commit-Position: refs/heads/master@{#366689}

Powered by Google App Engine
This is Rietveld 408576698