Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1541003003: Makes DatagramClientSocket::GetBoundNetwork const. (Closed)

Created:
5 years ago by Jana
Modified:
4 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@quicreader
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes DatagramClientSocket::GetBoundNetwork const. (Breaking out connection migration CL https://codereview.chromium.org/1327923002/.) R=rch@chromium.org,pauljensen@chromium.org BUG= Committed: https://crrev.com/2f5a8d25d40b898f8a4e689870c7764c839f5dc5 Cr-Commit-Position: refs/heads/master@{#367008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M net/dns/address_sorter_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socket_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socket_test_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/udp/datagram_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/udp/udp_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/udp/udp_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1543903002 Patch 1

Dependent Patchsets:

Issue 1549613002 Patch 1
Issue 1549613002 Patch 20001

Messages

Total messages: 8 (2 generated)
Jana
5 years ago (2015-12-22 20:53:24 UTC) #1
Ryan Hamilton
lgtm
5 years ago (2015-12-22 22:02:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541003003/1
4 years, 12 months ago (2015-12-28 18:49:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 20:16:36 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2f5a8d25d40b898f8a4e689870c7764c839f5dc5 Cr-Commit-Position: refs/heads/master@{#367008}
4 years, 12 months ago (2015-12-28 20:17:48 UTC) #7
pauljensen
4 years, 11 months ago (2015-12-29 13:23:22 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698