Compare case insensitively when copying answers into verbatim matches.

Compare case insensitively when copying answers into verbatim matches.

This avoids the case where an available answer is not shown because of a case mismatch (e.g. "US population" vs. "us population").

BUG=563621
Committed: https://crrev.com/622e2ed87916c89bef0ac75d7f288b8dfc11ac34
Cr-Commit-Position: refs/heads/master@{#367085}

[Justin Donnelly, 2015-12-22 20:23:18]

jdonnelly@chromium.org changed reviewers:
+ mpearson@chromium.org

[Justin Donnelly, 2015-12-22 20:24:22]

Description was changed from

==========
Compare case insensitively when copying answers into verbatim matches.

BUG=563621
==========

to

==========
Compare case insensitively when copying answers into verbatim matches.

This avoids the case where an available answer is not shown because of a case
mismatch (e.g. "US population" vs. "us population").

BUG=563621
==========

[Mark P, 2015-12-23 05:28:20]

lgtm with one minor suggestion below

--mark

https://codereview.chromium.org/1543803004/diff/1/components/omnibox/browser/...
File components/omnibox/browser/search_provider.cc (right):

https://codereview.chromium.org/1543803004/diff/1/components/omnibox/browser/...
components/omnibox/browser/search_provider.cc:933:
base::i18n::ToLower(trimmed_verbatim)) {
minor nit: consider explicitly creating a trimmed_verbatim_lowercased variable
outside this loop so you don't keep recomputing it each iteration.

[Justin Donnelly, 2015-12-29 17:24:42]

https://codereview.chromium.org/1543803004/diff/1/components/omnibox/browser/...
File components/omnibox/browser/search_provider.cc (right):

https://codereview.chromium.org/1543803004/diff/1/components/omnibox/browser/...
components/omnibox/browser/search_provider.cc:933:
base::i18n::ToLower(trimmed_verbatim)) {
On 2015/12/23 05:28:20, Mark P wrote:
> minor nit: consider explicitly creating a trimmed_verbatim_lowercased variable
> outside this loop so you don't keep recomputing it each iteration.

Done.

[Justin Donnelly, 2015-12-29 17:25:40]

The CQ bit was checked by jdonnelly@chromium.org

[Justin Donnelly, 2015-12-29 17:25:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/1543803004/#ps20001
(title: "Introduce trimmed_verbatim_lower variable")

[commit-bot: I haz the power, 2015-12-29 17:25:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1543803004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1543803004/20001

[commit-bot: I haz the power, 2015-12-29 18:18:15]

Description was changed from

==========
Compare case insensitively when copying answers into verbatim matches.

This avoids the case where an available answer is not shown because of a case
mismatch (e.g. "US population" vs. "us population").

BUG=563621
==========

to

==========
Compare case insensitively when copying answers into verbatim matches.

This avoids the case where an available answer is not shown because of a case
mismatch (e.g. "US population" vs. "us population").

BUG=563621
==========

[commit-bot: I haz the power, 2015-12-29 18:18:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-29 18:19:45]

Description was changed from

==========
Compare case insensitively when copying answers into verbatim matches.

This avoids the case where an available answer is not shown because of a case
mismatch (e.g. "US population" vs. "us population").

BUG=563621
==========

to

==========
Compare case insensitively when copying answers into verbatim matches.

This avoids the case where an available answer is not shown because of a case
mismatch (e.g. "US population" vs. "us population").

BUG=563621

Committed: https://crrev.com/622e2ed87916c89bef0ac75d7f288b8dfc11ac34
Cr-Commit-Position: refs/heads/master@{#367085}
==========

[commit-bot: I haz the power, 2015-12-29 18:19:45]

Patchset 2 (id:??) landed as
https://crrev.com/622e2ed87916c89bef0ac75d7f288b8dfc11ac34
Cr-Commit-Position: refs/heads/master@{#367085}