Compare case insensitively when copying answers into verbatim matches.

components/omnibox/browser/search_provider.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/search_provider.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/base64.h"
@@ skipping 910 matching lines @@
         base::CollapseWhitespace(input_.text(), false);
 
     // Verbatim results don't get suggestions and hence, answers.
     // Scan previous matches if the last answer-bearing suggestion matches
     // verbatim, and if so, copy over answer contents.
     base::string16 answer_contents;
     base::string16 answer_type;
     scoped_ptr<SuggestionAnswer> answer;
     for (ACMatches::iterator it = matches_.begin(); it != matches_.end();
          ++it) {
-      if (it->answer && it->fill_into_edit == trimmed_verbatim) {
+      if (it->answer &&
+          base::i18n::ToLower(it->fill_into_edit) ==
+              base::i18n::ToLower(trimmed_verbatim)) {

[Mark P, 2015/12/23 05:28:20]

minor nit: consider explicitly creating a trimmed_verbatim_lowercased variable
outside this loop so you don't keep recomputing it each iteration.

[Justin Donnelly, 2015/12/29 17:24:42]

Done.

         answer_contents = it->answer_contents;
         answer_type = it->answer_type;
         answer = SuggestionAnswer::copy(it->answer.get());
         break;
       }
     }
 
     SearchSuggestionParser::SuggestResult verbatim(
         trimmed_verbatim, AutocompleteMatchType::SEARCH_WHAT_YOU_TYPED,
         trimmed_verbatim, base::string16(), base::string16(), answer_contents,
@@ skipping 561 matching lines @@
   for (MatchMap::const_iterator i(map.begin()); i != map.end(); ++i)
     matches.push_back(i->second);
   std::sort(matches.begin(), matches.end(), &AutocompleteMatch::MoreRelevant);
 
   // If there is a top scoring entry, find the corresponding answer.
   if (!matches.empty())
     return answers_cache_.GetTopAnswerEntry(matches[0].contents);
 
   return AnswersQueryData();
 }