third_party/WebKit/Source/core/paint/FilterEffectBuilder.h - Issue 1543593002: Forward fill and stroke styles from 2d canvas to canvas filters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

Issue 1543593002: Forward fill and stroke styles from 2d canvas to canvas filters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.h ('K') | « third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp ('k') | third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp » ('j') | third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

diff --git a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

index 2c2f5aab5a9322333f83915695e664ff6617228c..974ffc387497f4447651cb19832e8fd7ff28809e 100644

--- a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

+++ b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

@@ -29,6 +29,7 @@

#include "core/CoreExport.h"

#include "platform/graphics/filters/FilterEffect.h"

#include "platform/heap/Handle.h"

+#include "third_party/skia/include/core/SkShader.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefCounted.h"

#include "wtf/RefPtr.h"

@@ -51,7 +52,7 @@ public:

virtual ~FilterEffectBuilder();

DECLARE_TRACE();

- bool build(Element*, const FilterOperations&, float zoom);

+ bool build(Element*, const FilterOperations&, float zoom, PassRefPtr<SkShader> fillShader = nullptr, PassRefPtr<SkShader> strokeShader = nullptr);

PassRefPtrWillBeRawPtr<FilterEffect> lastEffect() const

{