Forward fill and stroke styles from 2d canvas to canvas filters

third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.h

Index: third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.h
diff --git a/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.h b/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.h
index 505476ff9a1c3c1fdfd7a6ca8037d1206a04ff23..0ee9a2262e1d7b55d49da2d455af44c202d4cca5 100644
--- a/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.h
+++ b/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.h
@@ -32,6 +32,7 @@
 #define ReferenceFilterBuilder_h
 
 #include "core/fetch/DocumentResourceReference.h"
+#include "third_party/skia/include/core/SkShader.h"
 #include "wtf/Allocator.h"
 #include "wtf/HashMap.h"
 #include "wtf/PassRefPtr.h"
@@ -53,7 +54,7 @@ public:
     static void clearDocumentResourceReference(const FilterOperation*);
 #endif
 
-    static PassRefPtrWillBeRawPtr<Filter> build(float zoom, Element*, FilterEffect* previousEffect, const ReferenceFilterOperation&);
+    static PassRefPtrWillBeRawPtr<Filter> build(float zoom, Element*, FilterEffect* previousEffect, const ReferenceFilterOperation&, PassRefPtr<SkShader> fillShader = nullptr, PassRefPtr<SkShader> strokeShader = nullptr);

[Justin Novosad, 2015/12/21 18:10:27]

Are we sure SkShader is the right abstraction? I am concerned that we might end
up needing special behaviors that do map directly to skia (e.g. pattern tiling
modes). Possible alternatives that come to mind:
* blink:Image (which can be a GeneratedImage), 
* SkPaint, which can efficiently represent solid color styles, and can still
encapsulate an SkShader.  Also, are we comfortable with using SkShader directly
in core/layout/svg?

[f(malita), 2015/12/21 19:01:05]

+1 to making PaintFilterEffect SkPaint-based.

Then instead of CanvasStyle::asShader() we could have something like
applyToSkPaint (better aligned with SVGPaintServer::applyToSkPaint).

Maybe have a generalized PaintServer usable by both SVG & C2D?

[fs, 2015/12/21 19:34:20]

Yes, SkPaint would mesh slightly better with the (current) structure of SVG
paint servers - not that using SkShader would be overly problematic either
though.
I think I would off on that for now at least - where I see paint server setup
moving we'll likely not need that middle-man.

[ajuma, 2016/01/11 19:14:08]

This now uses SkPaint instead of SkShader.

 };
 
 }