Devirtualize isStretchingChildren

Devirtualize isStretchingChildren

There is no need for this to be virtual if we know the RenderObject is a RenderDeprecatedFlexibleBox, which we do here.
Also clean the method up a bit.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167017

[rwlbuis, 2014-02-05 19:41:10]

I am not sure if the devirtualize part of the patch is worth it. If not, I can
change this cl to keep (and maybe improve) the cleanups in
RenderBox::computeLogicalHeight.

[Inactive, 2014-02-05 21:12:18]

On 2014/02/05 19:41:10, rwlbuis wrote:
> I am not sure if the devirtualize part of the patch is worth it. If not, I can
> change this cl to keep (and maybe improve) the cleanups in
> RenderBox::computeLogicalHeight.

Can you add esprehn as reviewer? I'd prefer if he reviewed this.

[rwlbuis, 2014-02-05 21:17:32]

On 2014/02/05 21:12:18, Chris Dumez wrote:
> On 2014/02/05 19:41:10, rwlbuis wrote:
> > I am not sure if the devirtualize part of the patch is worth it. If not, I
can
> > change this cl to keep (and maybe improve) the cleanups in
> > RenderBox::computeLogicalHeight.
> 
> Can you add esprehn as reviewer? I'd prefer if he reviewed this.

Sure, will do.

[rwlbuis, 2014-02-05 21:18:54]

Adding esprehn, just a simple possible optimization patch. I think the cleanup
part is useful for sure (and maybe can be increased), not sure about the
devirtualization benefits.

[esprehn, 2014-02-10 23:50:55]

lgtm, seems like a reasonable refactor. It's nice to reduce the API surface on
RenderObject.

[esprehn, 2014-02-10 23:51:01]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-02-10 23:51:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/154343002/100001

[commit-bot: I haz the power, 2014-02-11 02:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-11 02:52:53]

Retried try job too often on linux_blink for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[rwlbuis, 2014-02-11 15:31:41]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-02-11 15:31:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/154343002/100001

[commit-bot: I haz the power, 2014-02-11 16:52:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-11 16:52:04]

Retried try job too often on linux_blink for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[rwlbuis, 2014-02-11 19:12:25]

On 2014/02/11 16:52:04, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_blink for step(s) webkit_unit_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

Oops, my cleanup triggers an assert in Debug, will fix...

[rwlbuis, 2014-02-12 15:11:36]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-02-12 15:11:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/154343002/400001

[commit-bot: I haz the power, 2014-02-12 16:32:21]

Change committed as 167017